From: "J. Bruce Fields" <bfields@fieldses.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@infradead.org>
Subject: Re: nfsd stuckage
Date: Thu, 8 Jan 2009 11:05:33 -0500 [thread overview]
Message-ID: <20090108160533.GA15690@fieldses.org> (raw)
In-Reply-To: <1231426650.11687.459.camel@twins>
On Thu, Jan 08, 2009 at 03:57:30PM +0100, Peter Zijlstra wrote:
> FWIW lockdep seems to warn about this...
>
> All I have to do to trigger this is boot the machine and let it sit for
> a few minutes.
Linus merged a fix (9a8d248e2d2 "nfsd: fix double-locks of directory
mutex") last night. If you still see warnings after that, let us know.
--b.
>
> [ 113.552497] =============================================
> [ 113.553289] [ INFO: possible recursive locking detected ]
> [ 113.553289] 2.6.28-tip #592
> [ 113.553289] ---------------------------------------------
> [ 113.553289] nfsd4/1914 is trying to acquire lock:
> [ 113.553289] (&type->i_mutex_dir_key#4){--..}, at: [<ffffffff802e7e5e>] vfs_fsync+0x6c/0xb1
> [ 113.553289]
> [ 113.553289] but task is already holding lock:
> [ 113.553289] (&type->i_mutex_dir_key#4){--..}, at: [<ffffffffa0190727>] nfsd4_sync_rec_dir+0x22/0x47 [nfsd]
> [ 113.553289]
> [ 113.553289] other info that might help us debug this:
> [ 113.553289] 4 locks held by nfsd4/1914:
> [ 113.553289] #0: (nfsd4){--..}, at: [<ffffffff80252303>] run_workqueue+0xb6/0x21b
> [ 113.553289] #1: ((laundromat_work).work){--..}, at: [<ffffffff80252303>] run_workqueue+0xb6/0x21b
> [ 113.553289] #2: (client_mutex){--..}, at: [<ffffffffa018bd05>] laundromat_main+0x33/0x24e [nfsd]
> [ 113.553289] #3: (&type->i_mutex_dir_key#4){--..}, at: [<ffffffffa0190727>] nfsd4_sync_rec_dir+0x22/0x47 [nfsd]
> [ 113.553289]
> [ 113.553289] stack backtrace:
> [ 113.553289] Pid: 1914, comm: nfsd4 Not tainted 2.6.28-tip #592
> [ 113.553289] Call Trace:
> [ 113.553289] [<ffffffff80266987>] __lock_acquire+0xe42/0x161a
> [ 113.553289] [<ffffffff80288857>] ? __call_rcu+0x7a/0x107
> [ 113.553289] [<ffffffff802671b4>] lock_acquire+0x55/0x71
> [ 113.553289] [<ffffffff802e7e5e>] ? vfs_fsync+0x6c/0xb1
> [ 113.553289] [<ffffffff805568d0>] mutex_lock_nested+0x4e/0x320
> [ 113.553289] [<ffffffff802e7e5e>] ? vfs_fsync+0x6c/0xb1
> [ 113.553289] [<ffffffff8029bde0>] ? __filemap_fdatawrite_range+0x57/0x5f
> [ 113.553289] [<ffffffff802e7e5e>] vfs_fsync+0x6c/0xb1
> [ 113.553289] [<ffffffffa0176f8f>] nfsd_sync_dir+0x15/0x17 [nfsd]
> [ 113.553289] [<ffffffffa0190733>] nfsd4_sync_rec_dir+0x2e/0x47 [nfsd]
> [ 113.553289] [<ffffffffa0190791>] nfsd4_recdir_purge_old+0x45/0x73 [nfsd]
> [ 113.553289] [<ffffffffa018bd44>] laundromat_main+0x72/0x24e [nfsd]
> [ 113.553289] [<ffffffff80252355>] run_workqueue+0x108/0x21b
> [ 113.553289] [<ffffffff80252303>] ? run_workqueue+0xb6/0x21b
> [ 113.553289] [<ffffffffa018bcd2>] ? laundromat_main+0x0/0x24e [nfsd]
> [ 113.553289] [<ffffffff8025254d>] worker_thread+0xe5/0xf6
> [ 113.553289] [<ffffffff80256615>] ? autoremove_wake_function+0x0/0x3d
> [ 113.553289] [<ffffffff80252468>] ? worker_thread+0x0/0xf6
> [ 113.553289] [<ffffffff80256200>] kthread+0x4e/0x7b
> [ 113.553289] [<ffffffff8020d51a>] child_rip+0xa/0x20
> [ 113.553289] [<ffffffff8020cec0>] ? restore_args+0x0/0x30
> [ 113.553289] [<ffffffff802561b2>] ? kthread+0x0/0x7b
> [ 113.553289] [<ffffffff8020d510>] ? child_rip+0x0/0x20
>
>
prev parent reply other threads:[~2009-01-08 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 22:56 nfsd stuckage Andrew Morton
2009-01-06 23:02 ` J. Bruce Fields
2009-01-06 23:03 ` Christoph Hellwig
2009-01-06 23:05 ` J. Bruce Fields
2009-01-07 0:15 ` J. Bruce Fields
2009-01-07 0:23 ` Andrew Morton
2009-01-07 0:28 ` J. Bruce Fields
2009-01-07 7:42 ` Christoph Hellwig
2009-01-07 16:56 ` J. Bruce Fields
2009-01-07 17:22 ` Christoph Hellwig
2009-01-08 14:57 ` Peter Zijlstra
2009-01-08 16:05 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108160533.GA15690@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.