All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Davide Rizzo <elpa.rizzo@gmail.com>
Cc: "Hans J. Koch" <hjk@linutronix.de>,
	linux-kernel@vger.kernel.org, ben-linux@fluff.org
Subject: Re: [PATCH 1/3] Driver for user access to internal clocks
Date: Thu, 8 Jan 2009 08:30:24 -0800	[thread overview]
Message-ID: <20090108163024.GB26413@suse.de> (raw)
In-Reply-To: <8447d6730901080806r238354c7u81071a28d8b483ff@mail.gmail.com>

On Thu, Jan 08, 2009 at 05:06:58PM +0100, Davide Rizzo wrote:
> > Davide,
> > please don't put this in the drivers/uio/ directory. This is no UIO driver.
> >
> > Thanks,
> > Hans
> >
> Ok, moved to /drivers/misc
> 
> This driver is for user level programs to interact with system clocks.

Same comments here as for your "timer.c" file:
	- too generic of a name
	- needs proper documentation
	- send any kernel api changes also to linux-api@vger.kernel.org

thanks,

greg k-h

  reply	other threads:[~2009-01-09  5:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08  9:49 [PATCH 1/3] Driver for user access to internal clocks Davide Rizzo
2009-01-08 11:27 ` Hans J. Koch
2009-01-08 16:06   ` Davide Rizzo
2009-01-08 16:30     ` Greg KH [this message]
2009-01-28 19:17       ` Davide Rizzo
     [not found]         ` <8447d6730901281117g3a8b7ddfp26e937111b6b6304-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-02-09 17:54           ` [PATCH 2/2] " Davide Rizzo
2009-02-09 17:54             ` Davide Rizzo
     [not found]       ` <20090108163024.GB26413-l3A5Bk7waGM@public.gmane.org>
2009-01-28 19:20         ` [PATCH 1/3] " Davide Rizzo
2009-01-28 19:20           ` Davide Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108163024.GB26413@suse.de \
    --to=gregkh@suse.de \
    --cc=ben-linux@fluff.org \
    --cc=elpa.rizzo@gmail.com \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.