From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, pq@iki.fi,
srostedt@redhat.com
Subject: Re: [PATCH 3/3] mmiotrace: count events lost due to not recording
Date: Thu, 8 Jan 2009 17:10:48 -0800 [thread overview]
Message-ID: <20090108171048.5e138f8d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090109002840.800960698@goodmis.org>
On Thu, 08 Jan 2009 19:27:50 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> +static atomic_t dropped_count;
Formally, this should be
static atomic_t dropped_count = ATOMIC_INIT(0);
but no atomic_t implementations need that, and I'm sure that if one
turns up wchih _does_ need it (say, it has a spinlock inside its
atomic_t) then the kernel would break all over the place.
So perhaps we should formally state that the all-zeroes pattern is an
acceptable way of initialising an atomic_t.
In which case these:
y:/usr/src/linux-2.6.28> grep -r "atomic_t.*=.*ATOMIC_INIT" . | wc -l
110
become cleanup fodder.
next prev parent reply other threads:[~2009-01-09 1:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 0:27 [PATCH 0/3] ftrace: updates for 2.6.29 Steven Rostedt
2009-01-09 0:27 ` [PATCH 1/3] doc: mmiotrace.txt, buffer size control change Steven Rostedt
2009-01-09 0:27 ` [PATCH 2/3] trace: mmiotrace to the tracer menu in Kconfig Steven Rostedt
2009-01-09 0:27 ` [PATCH 3/3] mmiotrace: count events lost due to not recording Steven Rostedt
2009-01-09 1:10 ` Andrew Morton [this message]
2009-01-09 1:56 ` Steven Rostedt
2009-01-09 20:04 ` [PATCH 0/3] ftrace: updates for 2.6.29 Pekka Paalanen
2009-01-11 3:06 ` Ingo Molnar
2009-02-15 18:58 ` Pekka Paalanen
2009-02-15 19:07 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2009-01-08 20:32 [PATCH 1/3] doc: update mmiotrace.txt Pekka Paalanen
2009-01-08 20:37 ` [PATCH 3/3] mmiotrace: count events lost due to not recording Pekka Paalanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108171048.5e138f8d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.