From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Thu, 08 Jan 2009 20:10:53 +0000 Subject: Re: [PATCH v2 0/5] Eliminate most of sparc_ksyms_*.c Message-Id: <20090108201053.GA8853@uranus.ravnborg.org> List-Id: References: <4965F1C6.1090700@gmail.com> In-Reply-To: <4965F1C6.1090700@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On Thu, Jan 08, 2009 at 09:03:35PM +0100, Sam Ravnborg wrote: > On Thu, Jan 08, 2009 at 11:29:58PM +1100, Julian Calaby wrote: > > Hi all, > > > > This patch set eliminates most of the definitions within > > arch/sparc/kernel/sparc_ksyms_*.c by moving them to their rightful places. > > > > This is done within patches 1-3. > > > > Note that this work was originally performed by Sam Ravnborg and these > > patches have been rebased and added to by myself. > > > > I've tried to reflect this in the commit messages but may have gotten it > > a little wrong. > > > > Patches 4 and 5 are cleanups that I had in my tree for an eventual > > oplib_*.h unification - but as this screws up my original patches and > > they're so small, I figured this'd be as good a time as any to send them. > > > > Changes in version 2: > > 1. Patches 2 and 3 have a few more includes added to the modified files. > > 2. It shouldn't be word wrapped this time! > > Hi Julian. > > I have tested your patches by applying them one-by-one > and done both sparc and sparc64 builds. > > Everything worked as expected - good work! I forgot to mention that I also looked through all the patches and everything looked good(*). (*) It does not look "good" that we have all the local declarations in ksyms.c but to eliminate them is another set of patches that has lower priority. Sam