From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: fix compile of xfs_btree_readahead_lblock on m68k
Date: Fri, 9 Jan 2009 09:42:47 +1100 [thread overview]
Message-ID: <20090108224247.GI9448@disturbed> (raw)
In-Reply-To: <20090108184429.823470000@bombadil.infradead.org>
On Thu, Jan 08, 2009 at 01:42:23PM -0500, Christoph Hellwig wrote:
> Change the left/right variables to the proper always 64bit xfs_dfsbo_t
> type because otherwise compilation fails for Geert on m68k without
> CONFIG_LBD:
>
> | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited range of data type
> | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited range of data type
>
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-08 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 18:42 [PATCH 0/3] regression fixes for 2.6.29 Christoph Hellwig
2009-01-08 18:42 ` [PATCH 1/3] xfs: fix compile of xfs_btree_readahead_lblock on m68k Christoph Hellwig
2009-01-08 22:42 ` Dave Chinner [this message]
2009-01-08 18:42 ` [PATCH 2/3] xfs: truncate readdir offsets to signed 32 bit values Christoph Hellwig
2009-01-08 19:00 ` Christoph Hellwig
2009-01-08 22:43 ` Dave Chinner
2009-01-08 18:42 ` [PATCH 3/3] xfs: make xfs_ino_t an unsigned long long Christoph Hellwig
2009-01-08 22:44 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108224247.GI9448@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.