From: Bastian Blank <bastian@waldi.eu.org>
To: frank.blaschka@de.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, ursula.braun@de.ibm.com
Subject: Re: [patch 1/4] lcs: convert to net_device_ops
Date: Fri, 9 Jan 2009 11:54:47 +0100 [thread overview]
Message-ID: <20090109105447.GA2929@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20090109090220.554541000@de.ibm.com>
On Fri, Jan 09, 2009 at 10:01:57AM +0100, frank.blaschka@de.ibm.com wrote:
> #ifdef CONFIG_IP_MULTICAST
> if (!lcs_check_multicast_support(card))
> - card->dev->set_multicast_list = lcs_set_multicast_list;
> + lcs_netdev_ops.ndo_set_multicast_list = lcs_set_multicast_list;
This looks wrong. lcs_netdev_ops is static but this code used to set it
up per card.
Bastian
--
History tends to exaggerate.
-- Col. Green, "The Savage Curtain", stardate 5906.4
next prev parent reply other threads:[~2009-01-09 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 9:01 [patch 0/4] s390: net drivers convert to net_device_ops frank.blaschka
2009-01-09 9:01 ` [patch 1/4] lcs: " frank.blaschka
2009-01-09 10:54 ` Bastian Blank [this message]
2009-01-09 12:18 ` Frank Blaschka
2009-01-09 16:36 ` Stephen Hemminger
2009-01-09 9:01 ` [patch 2/4] ctcm: " frank.blaschka
2009-01-09 9:01 ` [patch 3/4] netiucv: " frank.blaschka
2009-01-09 9:02 ` [patch 4/4] claw: " frank.blaschka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109105447.GA2929@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=davem@davemloft.net \
--cc=frank.blaschka@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.