From: Tony Lindgren <tony@atomide.com>
To: "Pillai, Manikandan" <mani.pillai@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] OMAP3 EVM MMC1 support for TPS based PR785 power modules
Date: Fri, 9 Jan 2009 14:13:14 +0200 [thread overview]
Message-ID: <20090109121310.GM2536@atomide.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739403ECEDDA84@dbde02.ent.ti.com>
Hi,
* Pillai, Manikandan <mani.pillai@ti.com> [090109 05:27]:
> Pls see my responses inline.
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > Sent: Thursday, January 08, 2009 8:57 PM
> > To: Pillai, Manikandan
> > Cc: linux-omap@vger.kernel.org
> > Subject: Re: [PATCH 1/1] OMAP3 EVM MMC1 support for TPS based PR785 power
> > modules
<snip>
> >
> > How about try to figure out a way to share the common code with
> > mmc-twl4030.c?
> [Pillai, Manikandan] Most of the code is derived from mmc-twl4030.c file.
> The intention was to have a different file for mmc-pr785.c. Are you suggesting
> here that I break the mmc-xxxx.c into 2 files mmc-shared.c and mmc-twl/pr785.c ?
Yeah we could have some shared file for those functions. How about
arch/arm/mach-omap2/hsmmc.c for the shared functions?
Tony
next prev parent reply other threads:[~2009-01-09 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 11:33 [PATCH 1/1] OMAP3 EVM MMC1 support for TPS based PR785 power modules Manikandan Pillai
2009-01-06 4:39 ` Pillai, Manikandan
2009-01-08 15:27 ` Tony Lindgren
2009-01-09 3:27 ` Pillai, Manikandan
2009-01-09 12:13 ` Tony Lindgren [this message]
2009-01-14 0:23 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109121310.GM2536@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=mani.pillai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.