From: Stephen Hemminger <shemminger@vyatta.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/2] netdev: missing validate_address hooks
Date: Fri, 9 Jan 2009 12:45:37 -0800 [thread overview]
Message-ID: <20090109124537.346c61d8@s6510> (raw)
In-Reply-To: <20090109124427.71d15306@s6510>
Some devices were converted incorrectly and are missing the validate
address hooks.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/acenic.c 2009-01-08 08:30:09.000000000 -0800
+++ b/drivers/net/acenic.c 2009-01-09 12:40:17.000000000 -0800
@@ -460,6 +460,7 @@ static const struct net_device_ops ace_n
.ndo_get_stats = ace_get_stats,
.ndo_start_xmit = ace_start_xmit,
.ndo_set_multicast_list = ace_set_multicast_list,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_set_mac_address = ace_set_mac_addr,
.ndo_change_mtu = ace_change_mtu,
#if ACENIC_DO_VLAN
--- a/drivers/net/arm/ks8695net.c 2009-01-08 08:30:09.000000000 -0800
+++ b/drivers/net/arm/ks8695net.c 2009-01-09 12:40:37.000000000 -0800
@@ -1357,6 +1357,7 @@ static const struct net_device_ops ks869
.ndo_start_xmit = ks8695_start_xmit,
.ndo_tx_timeout = ks8695_timeout,
.ndo_set_mac_address = ks8695_set_mac,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_set_multicast_list = ks8695_set_multicast,
};
--- a/drivers/net/mlx4/en_netdev.c 2009-01-08 08:30:12.000000000 -0800
+++ b/drivers/net/mlx4/en_netdev.c 2009-01-09 12:41:47.000000000 -0800
@@ -952,6 +952,7 @@ static const struct net_device_ops mlx4_
.ndo_get_stats = mlx4_en_get_stats,
.ndo_set_multicast_list = mlx4_en_set_multicast,
.ndo_set_mac_address = mlx4_en_set_mac,
+ .ndo_validate_addr = eth_validate_addr,
.ndo_change_mtu = mlx4_en_change_mtu,
.ndo_tx_timeout = mlx4_en_tx_timeout,
.ndo_vlan_rx_register = mlx4_en_vlan_rx_register,
next prev parent reply other threads:[~2009-01-09 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 20:44 [PATCH 1/2] netdev: add missing set_mac_address hook Stephen Hemminger
2009-01-09 20:45 ` Stephen Hemminger [this message]
2009-01-10 7:11 ` [PATCH 2/2] netdev: missing validate_address hooks David Miller
2009-01-09 21:13 ` [PATCH 1/2] netdev: add missing set_mac_address hook (rev2) Stephen Hemminger
2009-01-10 7:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109124537.346c61d8@s6510 \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.