From: Valerie Aurora Henson <vaurora@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: autofs@linux.kernel.org
Subject: Re: [PATCH 2/4] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit
Date: Fri, 9 Jan 2009 14:54:51 -0500 [thread overview]
Message-ID: <20090109195451.GI32333@shell> (raw)
In-Reply-To: <x49r63cfgpa.fsf@segfault.boston.devel.redhat.com>
On Fri, Jan 09, 2009 at 02:00:01PM -0500, Jeff Moyer wrote:
> Valerie Aurora Henson <vaurora@redhat.com> writes:
>
> > Signed-off-by: Valerie Aurora Henson <vaurora@redhat.com>
>
> > @@ -1524,18 +1525,12 @@ int lookup_read_master(struct master *master, time_t age, void *context)
> > goto next;
> > }
> >
> > - blen = strlen(*keyValue) + 1 + strlen(*values) + 2;
> > - if (blen > PARSE_MAX_BUF) {
> > + if (snprintf(parse_buf, sizeof(parse_buf), "%s %s",
> > + *keyValue, *values) > sizeof(parse_buf)) {
>
> I think this should be >=.
Yes, they all should be. I'll regenerate. Thanks,
-VAL
next prev parent reply other threads:[~2009-01-09 19:54 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 18:46 [PATCH 0/4] autofs scaling and cleanup patches Valerie Aurora Henson
2009-01-09 18:47 ` [PATCH 1/4] Make hash table scale to thousands of entries Valerie Aurora Henson
2009-01-09 18:47 ` [PATCH 2/4] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit Valerie Aurora Henson
2009-01-09 18:47 ` [PATCH 3/4] Easy alloca() replacements Valerie Aurora Henson
2009-01-09 18:47 ` [PATCH 4/4] Replace <linux/string.h> with <string.h> Valerie Aurora Henson
2009-01-12 5:59 ` Ian Kent
2009-01-09 20:48 ` [PATCH 3/4] Easy alloca() replacements Valerie Aurora Henson
2009-01-10 3:18 ` Ian Kent
2009-01-16 22:11 ` Valerie Aurora Henson
2009-01-09 19:00 ` [PATCH 2/4] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit Jeff Moyer
2009-01-09 19:54 ` Valerie Aurora Henson [this message]
2009-01-09 19:17 ` [PATCH 1/4] Make hash table scale to thousands of entries Jeff Moyer
2009-01-09 19:51 ` Valerie Aurora Henson
2009-01-10 1:19 ` Paul Wankadia
2009-01-11 16:42 ` Ian Kent
2009-01-11 23:25 ` Paul Wankadia
2009-01-12 1:13 ` Ian Kent
2009-01-12 1:19 ` Ian Kent
2009-01-12 2:10 ` Paul Wankadia
2009-01-12 4:02 ` Ian Kent
2009-01-12 4:58 ` Ian Kent
2009-01-13 1:52 ` Paul Wankadia
2009-01-13 2:24 ` Ian Kent
2009-01-13 4:15 ` Ian Kent
2009-01-13 5:07 ` Paul Wankadia
2009-01-13 5:19 ` Ian Kent
2009-01-14 3:43 ` Paul Wankadia
2009-01-14 8:47 ` Ian Kent
2009-01-14 10:52 ` Paul Wankadia
2009-01-14 13:17 ` Ian Kent
2009-01-14 14:20 ` Paul Wankadia
2009-01-15 1:41 ` Ian Kent
2009-01-15 15:04 ` Jeff Moyer
2009-01-15 15:16 ` Ian Kent
2009-01-15 20:33 ` Paul Wankadia
2009-01-15 20:41 ` Jeff Moyer
2009-01-15 20:57 ` Paul Wankadia
2009-01-16 0:27 ` Ian Kent
2009-01-16 0:40 ` Ian Kent
2009-01-16 1:43 ` Ian Kent
2009-01-16 3:59 ` Paul Wankadia
2009-01-16 4:21 ` Ian Kent
2009-01-16 5:05 ` Ian Kent
2009-01-16 6:04 ` Paul Wankadia
2009-01-16 6:24 ` Ian Kent
2009-01-16 6:39 ` Ian Kent
2009-01-17 17:11 ` Paul Wankadia
2009-01-18 3:26 ` Ian Kent
2009-01-19 1:28 ` Paul Wankadia
2009-01-19 2:03 ` Ian Kent
2009-01-19 5:23 ` Paul Wankadia
2009-01-19 6:13 ` Ian Kent
2009-01-16 5:23 ` Ian Kent
2009-01-16 0:33 ` Ian Kent
2009-01-10 14:45 ` Ian Kent
2009-01-10 2:07 ` Ian Kent
2009-01-10 3:29 ` Ian Kent
2009-01-10 3:57 ` Ian Kent
2009-01-13 5:51 ` Ian Kent
2009-01-14 3:58 ` Paul Wankadia
2009-01-14 8:48 ` Ian Kent
2009-01-15 2:47 ` Valerie Aurora Henson
2009-01-15 3:02 ` Ian Kent
2009-01-16 21:39 ` Valerie Aurora Henson
2009-01-15 5:06 ` Paul Wankadia
2009-01-15 4:42 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109195451.GI32333@shell \
--to=vaurora@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.