From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Martin Michlmayr <tbm@cyrius.com>,
linux-scsi@vger.kernel.org
Subject: Re: [patch 10/11] scsi: fix bad use of udelay in atp870u.c
Date: Sat, 10 Jan 2009 10:50:11 -0500 [thread overview]
Message-ID: <20090110155011.GA22062@infradead.org> (raw)
In-Reply-To: <1231536107.3235.50.camel@localhost.localdomain>
On Fri, Jan 09, 2009 at 03:21:47PM -0600, James Bottomley wrote:
> It's wrong to silence a warning or build break while keeping the effect
> it was complaining about it's hiding a bug. Now if the warning is
> wrong, we can take it out of the ARM build ... but I've got to say it
> looks right: the udelay in this driver will lock a UP system solid for
> 2ms.
mdelay exist for a reason. Even if this code is really bad adding
a comment about that and moving on is better than leaving the too large
udelay there.
next prev parent reply other threads:[~2009-01-10 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 20:28 [patch 10/11] scsi: fix bad use of udelay in atp870u.c akpm
2009-01-09 20:58 ` Martin Michlmayr
2009-01-09 21:03 ` Andrew Morton
2009-01-09 21:21 ` James Bottomley
2009-01-10 15:50 ` Christoph Hellwig [this message]
2012-04-24 7:49 ` [PATCH/RFC v2] [SCSI] atp870u: Fix bad use of udelay Jonathan Nieder
2012-04-24 7:49 ` Jonathan Nieder
2012-04-24 21:18 ` Andrew Morton
2012-04-24 21:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110155011.GA22062@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.