From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: "Ryan Alberts" <ralberts@gmail.com>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]
Date: Sat, 10 Jan 2009 21:34:05 +0100 [thread overview]
Message-ID: <200901102134.05652.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <142772020901071910ha95d53fo2454f8685908338c@mail.gmail.com>
torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:
> I have attached a small fix for when a git config has /r lines in the file.
> I have to admit that I do not usually submit patches to the open source
> community and I am not very familiar with the process :-) Please, please,
> let me know if I can do something different next time!
1) Inline the patch
No, need for such a large sign-off. It's good you declare that you have
understand the SOB-line.
You can add "extra" comments that should not go into the cBommit after the
comment like this:
From:.. etc
"This" goes into the commit
Signed-off-by: Whom Ever <whom.ever@example.com>
---
The three dashes ends the comment. Anything after it and the actual patch
will be ignored by git am, but might be useful to the maintainer.
Back to the patch. I think we should only ignore \r (not /r, but could say CR in
a comment) before an LF.
-- robin
next parent reply other threads:[~2009-01-10 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <142772020901071910ha95d53fo2454f8685908338c@mail.gmail.com>
2009-01-10 20:34 ` Robin Rosenberg [this message]
2009-01-12 17:10 ` [PATCH EGIT Allow for git config to not error when lines have '/r' in them.] Shawn O. Pearce
2009-01-12 22:53 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901102134.05652.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=ralberts@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.