All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
	mbligh@google.com, thockin@google.com
Subject: Re: [PATCH v2] softlockup: decouple hung tasks check from softlockup detection
Date: Mon, 12 Jan 2009 10:03:07 +0100	[thread overview]
Message-ID: <20090112090307.GC26750@elte.hu> (raw)
In-Reply-To: <20090112065213.GA19795@google.com>


* Mandeep Singh Baines <msb@google.com> wrote:

> Decoupling allows:
> 
> * hung tasks check to happen at very low priority
> * hung tasks check and softlockup to be enabled/disabled independently
>   at compile and/or run-time
> * individual panic settings to be enabled disabled independently
>   at compile and/or run-time
> * softlockup threshold to be reduced without increasing hung tasks
>   poll frequency (hung task check is expensive relative to softlock watchdog)
> * hung task check to be zero over-head when disabled at run-time
> ---
>  include/linux/sched.h |   14 +++++--
>  kernel/Makefile       |    1 +
>  kernel/softlockup.c   |  102 -------------------------------------------------
>  kernel/sysctl.c       |   15 +++++++-
>  lib/Kconfig.debug     |   38 ++++++++++++++++++
>  5 files changed, 63 insertions(+), 107 deletions(-)

Looks good in principle, but i suspect your patch submission should 
include the new kernel/hung_task.c file too ;-)

	Ingo

  reply	other threads:[~2009-01-12  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12  6:52 [PATCH v2] softlockup: decouple hung tasks check from softlockup detection Mandeep Singh Baines
2009-01-12  9:03 ` Ingo Molnar [this message]
2009-01-12 17:58   ` [PATCH v3] " Mandeep Singh Baines
2009-01-14 10:54     ` Ingo Molnar
2009-01-15 19:08       ` [PATCH v4] " Mandeep Singh Baines
2009-01-16 13:06         ` Ingo Molnar
2009-01-16 13:24           ` Ingo Molnar
2009-01-12 14:32 ` [PATCH v2] " Johannes Weiner
2009-01-16 16:58 ` Frédéric Weisbecker
2009-01-17  4:13   ` Mandeep Singh Baines
2009-01-17 14:07     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112090307.GC26750@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=msb@google.com \
    --cc=rientjes@google.com \
    --cc=thockin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.