From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: linux-next: origin tree build failure Date: Mon, 12 Jan 2009 10:05:52 +0100 Message-ID: <20090112090552.GD26750@elte.hu> References: <20090112104837.69feedec.sfr@canb.auug.org.au> <1231719015.22571.4.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:50712 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbZALJGX (ORCPT ); Mon, 12 Jan 2009 04:06:23 -0500 Content-Disposition: inline In-Reply-To: <1231719015.22571.4.camel@pasglop> Sender: linux-next-owner@vger.kernel.org List-ID: To: Benjamin Herrenschmidt Cc: Stephen Rothwell , Linus Torvalds , linux-next@vger.kernel.org, Rusty Russell , Mike Travis , Andrew Morton , "David S. Miller" , LKML , Paul Mackerras , linuxppc-dev@ozlabs.org * Benjamin Herrenschmidt wrote: > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote: > > Hi Linus, > > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init': > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init': > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init': > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment > > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask: > > convert struct cpufreq_policy to cpumask_var_t") which missed updating > > all the powerpc (at least) cpufreq drivers. > > Yeah, it only updates x86 it seems ... Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ... It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig. Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fallback.mail.elte.hu (fallback.mail.elte.hu [157.181.151.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 97422DE012 for ; Mon, 12 Jan 2009 20:06:29 +1100 (EST) Received: from mx3.mail.elte.hu ([157.181.1.138]) by fallback.mail.elte.hu with esmtp (Exim) id 1LMIkZ-0002Ph-Sc from for ; Mon, 12 Jan 2009 10:06:23 +0100 Date: Mon, 12 Jan 2009 10:05:52 +0100 From: Ingo Molnar To: Benjamin Herrenschmidt Subject: Re: linux-next: origin tree build failure Message-ID: <20090112090552.GD26750@elte.hu> References: <20090112104837.69feedec.sfr@canb.auug.org.au> <1231719015.22571.4.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1231719015.22571.4.camel@pasglop> Cc: Stephen Rothwell , Rusty Russell , LKML , Mike Travis , linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, Paul Mackerras , Andrew Morton , Linus Torvalds , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Benjamin Herrenschmidt wrote: > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote: > > Hi Linus, > > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init': > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init': > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init': > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment > > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask: > > convert struct cpufreq_policy to cpumask_var_t") which missed updating > > all the powerpc (at least) cpufreq drivers. > > Yeah, it only updates x86 it seems ... Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ... It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig. Ingo