From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/liberation
Date: Mon, 12 Jan 2009 14:05:44 +0100 [thread overview]
Message-ID: <20090112130544.GA32253@mx.loc> (raw)
In-Reply-To: <20090112124048.BBE95766E4@busybox.osuosl.org>
On Mon, Jan 12, 2009 at 12:40:48PM +0000, laird at uclibc.org wrote:
>Author: laird
>Date: 2009-01-12 12:40:48 +0000 (Mon, 12 Jan 2009)
>New Revision: 24792
>
>Log:
>package/liberation/liberation.mk: Correct the makefile to what it should have been
>
>Correct the makefile so that it works and is what I originally planned to add.
>
>Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>
>
>
>
>Modified:
> trunk/buildroot/package/liberation/liberation.mk
>
>
>Changeset:
>Modified: trunk/buildroot/package/liberation/liberation.mk
>===================================================================
>--- trunk/buildroot/package/liberation/liberation.mk 2009-01-12 10:29:46 UTC (rev 24791)
>+++ trunk/buildroot/package/liberation/liberation.mk 2009-01-12 12:40:48 UTC (rev 24792)
>@@ -18,12 +18,12 @@
> $(LIBERATION_CAT) $(DL_DIR)/$(LIBERATION_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
> touch $(LIBERATION_DIR)/.unpacked
touch $@
>
>-$(STAGING_DIR)/usr/share/fonts/.ttf: $(LIBERATION_DIR)/.unpacked
>+$(STAGING_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(LIBERATION_DIR)/.unpacked
> -mkdir -p $(STAGING_DIR)/usr/share/fonts/liberation
The preferred thing to do is to use $(INSTALL) -d $(@D)
> $(INSTALL) -m0644 $(LIBERATION_DIR)/*.ttf $(STAGING_DIR)/usr/share/fonts/liberation/
okay.. the target is fonts/LiberationMono-Bold.ttf and you put the fonts into
fonts/liberation/
> touch -c $(STAGING_DIR)/usr/share/fonts/.ttf
See how it would be *so* much better to use 'touch -c $@' ?
>
>-$(TARGET_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(STAGING_DIR)/usr/share/fonts/.ttf
>+$(TARGET_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(STAGING_DIR)/usr/share/fonts/LiberationMono-Bold.ttf
> -mkdir -p $(TARGET_DIR)/usr/share/fonts/liberation
> $(INSTALL) -m0644 $(LIBERATION_DIR)/*.ttf $(TARGET_DIR)/usr/share/fonts/liberation/
> touch -c $(TARGET_DIR)/usr/share/fonts/.ttf
about the same 3 bugs as above.
Please, be more careful..
next prev parent reply other threads:[~2009-01-12 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 12:40 [Buildroot] svn commit: trunk/buildroot/package/liberation laird at uclibc.org
2009-01-12 13:05 ` Bernhard Reutner-Fischer [this message]
2009-01-12 14:19 ` Daniel James Laird
2009-01-13 0:28 ` Hamish Moffatt
2009-01-13 6:09 ` Peter Korsgaard
2009-01-13 7:30 ` danieljlaird at hotmail.com
-- strict thread matches above, loose matches on Subject: below --
2009-01-13 10:37 laird at uclibc.org
2009-01-15 21:52 ` Ulf Samuelsson
2009-01-15 23:15 ` Peter Korsgaard
2009-01-16 6:46 ` Ulf Samuelsson
2009-01-10 0:20 ulf at uclibc.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112130544.GA32253@mx.loc \
--to=rep.dot.nop@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.