From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [patch 4/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs Date: Mon, 12 Jan 2009 15:03:16 +0100 Message-ID: <200901121503.17232.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Keir Fraser , "Ke, Liping" List-Id: xen-devel@lists.xenproject.org On Friday 19 December 2008 07:19:16 Ke, Liping wrote: > Hi, all > > Patch 4 is the main patch for CMCI enabling in XEN. It adds the CMCI > interrupt handler, new common CMCI/MCA init process,CMCI owner judge > algorithm when bring_up CPUs, CPU on/offline and polling mechanisms, etc > > Thanks & Regards, > Criping This patch changes the public API. There's no need to change struct mcinfo_extended. The marshalling technique allows to use this structure as often as needed. Please undo this change. struct mcinfo_global is also changed. Why can't mc_coreid not be filled with the apicid ? Adding the apicid field breaks the alignment causing troubles on 32bit-guest-on-64bit-hypervisor. Christoph =2D-=20 Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34 85609 Dornach b. M=FCnchen =20 Gesch=E4ftsf=FChrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen Registergericht M=FCnchen, HRB Nr. 43632