From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>,
"Alexey Klimov"
<klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
"Greg KH" <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers
Date: Tue, 13 Jan 2009 01:44:25 -0800 [thread overview]
Message-ID: <200901130144.26162.david-b@pacbell.net> (raw)
In-Reply-To: <200901131025.40285.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
On Tuesday 13 January 2009, Oliver Neukum wrote:
> > Ok, i'll reformat patch. Is it okay if i use kaweth->dev->dev,
> > kaweth->net->dev and intf->dev ? Or switch to kaweth->net->dev
> > (instead of dev->dev)?
>
> kaweth in kaweth_disconnect() frees the network device. Therefore
> you cannot use it. You'd access freed memory. Pick one of the others
> and stay with it.
intf->dev is going to be "obviously correct", the others aren't.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-13 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 0:08 [patch v2] net/usb: remove err() messages in few drivers Alexey Klimov
[not found] ` <1231805322.12962.4.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
2009-01-13 8:40 ` Oliver Neukum
2009-01-13 8:57 ` Alexey Klimov
2009-01-13 9:25 ` Oliver Neukum
[not found] ` <200901131025.40285.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-13 9:44 ` David Brownell [this message]
2009-01-13 10:08 ` Alexey Klimov
2009-01-13 11:07 ` Oliver Neukum
[not found] ` <200901131207.03724.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-14 0:22 ` Alexey Klimov
[not found] ` <208cbae30901131622heccfee6uf312022ba1d4fb28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-14 1:05 ` David Brownell
2009-01-14 8:09 ` Oliver Neukum
2009-01-13 9:46 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901130144.26162.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.