All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
	Jesper.Nilsson@axis.com, tj@kernel.org,
	stern@rowland.harvard.edu, jens.axboe@oracle.com,
	hinko.kocevar@cetrtapot.si, linux-kernel@vger.kernel.org
Subject: Re: lib/klist.c: bit 0 in pointer can't be used as flag
Date: Tue, 13 Jan 2009 15:59:14 -0800	[thread overview]
Message-ID: <20090113235914.GA20727@suse.de> (raw)
In-Reply-To: <20090114085341.442C.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Wed, Jan 14, 2009 at 08:54:20AM +0900, KOSAKI Motohiro wrote:
> > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Date: Wed, 14 Jan 2009 07:40:19 +0900
> > 
> > > > It may be that we've worked around the other spots, although I haven't
> > > > seen anything like that, we might just have been lucky until now.
> > > >
> > > > Can you recall another place where this trick is used?
> > > 
> > > rmap.
> > > Don't CRIS use mmu?
> > 
> > I'm beginning to suspect the issue is only with objects
> > in the kernel image itself.  Dynamically allocated memory
> > is properly aligned and therefore the "low bit status bits
> > in pointer" trick works.
> 
> Ah, I see.
> very thank you for helpful explain.

So, is this change still needed for klists?  I'm guessing so as they
could be in statically allocated objects, right?

Here's yet another reason to never statically allocate a kobject...

thanks,

greg k-h

  reply	other threads:[~2009-01-14  0:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 15:14 lib/klist.c: bit 0 in pointer can't be used as flag Jesper Nilsson
2009-01-13 21:10 ` David Miller
2009-01-13 22:12   ` Jesper Nilsson
2009-01-13 22:40     ` KOSAKI Motohiro
2009-01-13 22:45       ` David Miller
2009-01-13 23:11         ` Bastien ROUCARIES
2009-01-14 10:19           ` Jesper Nilsson
2009-01-14 10:21             ` David Miller
2009-01-14 10:36               ` Jesper Nilsson
2009-01-14 10:45                 ` David Miller
2009-01-14 11:02                   ` Jesper Nilsson
2009-01-14 15:12                   ` Jesper Nilsson
2009-01-14 18:17                     ` Greg KH
2009-01-14 21:53                       ` Jesper Nilsson
2009-01-13 23:54         ` KOSAKI Motohiro
2009-01-13 23:59           ` Greg KH [this message]
2009-01-14 10:25             ` Jesper Nilsson
2009-01-14  0:33         ` Hugh Dickins
2009-01-14 10:18         ` Jesper Nilsson
2009-01-13 22:42     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090113235914.GA20727@suse.de \
    --to=gregkh@suse.de \
    --cc=Jesper.Nilsson@axis.com \
    --cc=davem@davemloft.net \
    --cc=hinko.kocevar@cetrtapot.si \
    --cc=jens.axboe@oracle.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.