From: Evgeniy Polyakov <zbr@ioremap.net>
To: Yehuda Sadeh Weinraub <yehudasa@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [4/9] pohmelfs: directory operations.
Date: Wed, 14 Jan 2009 04:31:40 +0300 [thread overview]
Message-ID: <20090114013140.GA3907@ioremap.net> (raw)
In-Reply-To: <a37615150901131728v3f27bf01le18c5640cb38a30e@mail.gmail.com>
On Tue, Jan 13, 2009 at 05:28:29PM -0800, Yehuda Sadeh Weinraub (yehudasa@gmail.com) wrote:
> > They should be implemented already in the change attribute code.
> > Attribute changes are flushed at writeback time or on server's demand.
> >
> ok, might be that the following is the problem:
>
> int pohmelfs_setattr(struct dentry *dentry, struct iattr *attr)
> {
> ...
> if (!(psb->state_flags & POHMELFS_FLAGS_XATTR))
> return -EOPNOTSUPP;
>
>
> Probably this test should be only on setxattr?
Definitely :)
It should be moved there. Thanks for spotting this.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-01-14 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 0:43 [4/9] pohmelfs: directory operations Yehuda Sadeh Weinraub
2009-01-14 1:07 ` Evgeniy Polyakov
2009-01-14 1:28 ` Yehuda Sadeh Weinraub
2009-01-14 1:31 ` Evgeniy Polyakov [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 14:02 [0/9] pohmelfs for drivers/staging Evgeniy Polyakov
2009-02-09 14:02 ` [1/9] pohmelfs: documentation Evgeniy Polyakov
2009-02-09 14:02 ` [2/9] pohmelfs: configuration interface Evgeniy Polyakov
2009-02-09 14:02 ` [3/9] pohmelfs: crypto processing Evgeniy Polyakov
2009-02-09 14:02 ` [4/9] pohmelfs: directory operations Evgeniy Polyakov
2008-12-26 14:18 [0/9] pohmelfs: The Great Southern Trendkill release Evgeniy Polyakov
2008-12-26 14:18 ` [1/9] pohmelfs: documentation Evgeniy Polyakov
2008-12-26 14:18 ` [2/9] pohmelfs: configuration interface Evgeniy Polyakov
2008-12-26 14:18 ` [3/9] pohmelfs: crypto processing Evgeniy Polyakov
2008-12-26 14:18 ` [4/9] pohmelfs: directory operations Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114013140.GA3907@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yehudasa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.