From: Florian Fainelli <florian@openwrt.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jeff@garzik.org
Subject: Re: [PATCH] korina: fix handling tx_chain_tail
Date: Wed, 14 Jan 2009 19:00:14 +0100 [thread overview]
Message-ID: <200901141900.14616.florian@openwrt.org> (raw)
In-Reply-To: <1231955510-12240-1-git-send-email-n0-1@freewrt.org>
Le Wednesday 14 January 2009 18:51:50 Phil Sutter, vous avez écrit :
> Originally this must have been a rewrite error when introducing
> 'chain_index'. But the original driver did not use the previous chain
> item everywhere: when altering the address tx_chain_tail points to, it
> should move forward, not backwards.
I think this was in the original driver as well.
> Also this is not an "index" but rather the penultimate element in the
> chain, so rename it accordingly.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Acked-by: Florian Fainelli <florian@openwrt.org>
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-01-14 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1231955400-9745-1-git-send-email-n0-1@freewrt.org>
2009-01-14 17:57 ` [PATCH] korina: reset resource buffer size to 1536 Florian Fainelli
2009-01-15 5:47 ` David Miller
[not found] ` <1231955448-10877-1-git-send-email-n0-1@freewrt.org>
2009-01-14 17:58 ` [PATCH] korina: disable napi on close and restart Florian Fainelli
2009-01-15 5:48 ` David Miller
[not found] ` <1231955461-11187-1-git-send-email-n0-1@freewrt.org>
2009-01-14 17:58 ` [PATCH] korina: rework korina_rx() for use with napi Florian Fainelli
2009-01-15 5:49 ` David Miller
[not found] ` <1231955478-11495-1-git-send-email-n0-1@freewrt.org>
2009-01-14 17:59 ` [PATCH] korina: do schedule napi after testing for it Florian Fainelli
2009-01-15 5:49 ` David Miller
[not found] ` <1231955495-11911-1-git-send-email-n0-1@freewrt.org>
2009-01-14 17:59 ` [PATCH] korina: do tx at the right position Florian Fainelli
2009-01-15 5:50 ` David Miller
[not found] ` <1231955510-12240-1-git-send-email-n0-1@freewrt.org>
2009-01-14 18:00 ` Florian Fainelli [this message]
2009-01-14 18:21 ` [PATCH] korina: fix handling tx_chain_tail Phil Sutter
2009-01-15 5:50 ` David Miller
[not found] ` <1231955526-12600-1-git-send-email-n0-1@freewrt.org>
2009-01-14 18:00 ` [PATCH] korina: do not stop queue here Florian Fainelli
2009-01-15 5:51 ` David Miller
[not found] ` <1231955540-12886-1-git-send-email-n0-1@freewrt.org>
2009-01-14 18:00 ` [PATCH] korina: do not use IRQF_SHARED with IRQF_DISABLED Florian Fainelli
2009-01-15 5:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901141900.14616.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=n0-1@freewrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.