Re: [PATCH take 3 0/4] color-words improvements

[Thomas Rast <trast@student.ethz.ch>]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Johannes Schindelin wrote:
> > Ack on the new regex semantics, though I'd have implemented it via dying 
> > on '\n' instead of silently splitting there (and restarting a new 
> > match!).
> 
> Hmm.  I'd rather not die() in the middle of it.
> 
> Maybe we can even handle newlines correctly by replacing them with NULs 
> which libxdiff handles just fine?

I'm not sure it's worth the effort---anyone who wants words to stick
together across newlines probably doesn't put a newline there in the
first place, don't they?  (And it just shifts the problem to another
special character.)

> Phew.  I was almost convinced you would hate me for my criticiscm.

Let's say I wasn't too happy when you asked for two rounds of
improvements and _then_ rejected.  But the end result certainly turned
out better, so the criticism was justified.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]