From: "Shawn O. Pearce" <spearce@spearce.org>
To: ted@tedpavlic.com
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3] bash-completion: Added comments to remind about required arguments
Date: Thu, 15 Jan 2009 07:35:43 -0800 [thread overview]
Message-ID: <20090115153543.GF10179@spearce.org> (raw)
In-Reply-To: <1231963342-24461-3-git-send-email-ted@tedpavlic.com>
ted@tedpavlic.com wrote:
> From: Ted Pavlic <ted@tedpavlic.com>
>
> Adds a few simple comments above commands that take arguments. These
> comments are meant to remind developers of potential problems that can
> occur when the script is sourced on systems with "set -u." Any
> function which "requires" arguments really ought to be called with
> explicit arguments given.
>
> Also adds a #!bash to the top of bash completions so that editing
> software can always identify that the file is of sh type.
>
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
Yup, this and also 2/3 look fine. But again, the message, it
shouldn't be indented.
> ---
> contrib/completion/git-completion.bash | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
--
Shawn.
next prev parent reply other threads:[~2009-01-15 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 20:02 [PATCH 1/3] bash-completion: Support running when set -u is enabled ted
2009-01-14 20:02 ` [PATCH 2/3] bash-completion: Try bash completions before simple filetype ted
2009-01-14 20:02 ` [PATCH 3/3] bash-completion: Added comments to remind about required arguments ted
2009-01-15 15:35 ` Shawn O. Pearce [this message]
2009-01-15 15:47 ` Ted Pavlic
2009-01-15 15:34 ` [PATCH 1/3] bash-completion: Support running when set -u is enabled Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115153543.GF10179@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.