From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (abituguru3) Fix CONFIG_DMI=n
Date: Thu, 15 Jan 2009 18:02:09 +0000 [thread overview]
Message-ID: <20090115190209.7c60918f@hyperion.delvare> (raw)
In-Reply-To: <200901151701.47672.alistair@devzero.co.uk>
On Thu, 15 Jan 2009 17:01:47 +0000, Alistair John Strachan wrote:
> When CONFIG_DMI is not enabled, dmi detection should flag that no board
> could be detected (err=1) rather than another error condition (err<0).
>
> This fixes the fallback to manual probing for all motherboards, even
> those without DMI strings, when CONFIG_DMI=n.
>
> Signed-off-by: Alistair John Strachan <alistair@devzero.co.uk>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/abituguru3.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
> index 70bb854..fcf74eb 100644
> --- a/drivers/hwmon/abituguru3.c
> +++ b/drivers/hwmon/abituguru3.c
> @@ -1153,7 +1153,7 @@ static int __init abituguru3_dmi_detect(void)
>
> static inline int abituguru3_dmi_detect(void)
> {
> - return -ENODEV;
> + return 1;
> }
>
> #endif /* CONFIG_DMI */
>
Applied, thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-01-15 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 17:01 [lm-sensors] [PATCH] hwmon: (abituguru3) Fix CONFIG_DMI=n fallback Alistair John Strachan
2009-01-15 18:02 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115190209.7c60918f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.