All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: wk <handygewinnspiel@gmx.de>
Cc: Chris Mason <chris.mason@oracle.com>,
	Matthew Wilcox <matthew@wil.cx>,
	Andrew Morton <akpm@linux-foundation.org>,
	rjw@sisk.pl, HWerner4@gmx.de, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	mchehab@infradead.org
Subject: Re: [linux-dvb] compiling on 2.6.28 broken?
Date: Fri, 16 Jan 2009 09:23:54 +1100	[thread overview]
Message-ID: <20090115222354.GG8071@disturbed> (raw)
In-Reply-To: <496F9174.5080907@gmx.de>

On Thu, Jan 15, 2009 at 08:41:40PM +0100, wk wrote:
> Dave Chinner wrote:
>> It's obviously the regression fixed by:
>>
>> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=commit;h=15440319767942a363f282d6585303d3d75088ba
>>
>> It needs to be pushed to Linus, then into 2.6.28-stable.
>
> Yes, that solves the problems as expected. But may i kindly ask the xfs  
> fs developers to put some more readable patch here,
> so that its better understandable by looking at the source code? I think  
> some macro would be better here, for example i used
>
> #define TRUNC_TO_SIGNED32(x) (x & 0x7FFFFFFF)
>
> inside xfs.h and replaced all "foo & 0x7fffffff" with  
> "TRUNC_TO_SIGNED32(foo)".

>From the commit description:

"The patch below is a dumb version of just putting back the masking,
 to make sure we have the same behavior as in 2.6.27 and earlier.

 I will work on a better and cleaner fix for 2.6.30."

And in more detail, read the review thread:

http://oss.sgi.com/archives/xfs/2008-12/msg01168.html

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2009-01-15 22:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090112190420.51f75853@pedra.chehab.org>
     [not found] ` <20090112132130.6c932b85.akpm@linux-foundation.org>
     [not found]   ` <20090112220624.4fbfee34@pedra.chehab.org>
     [not found]     ` <20090112162337.318dd61d.akpm@linux-foundation.org>
2009-01-13 18:47       ` [linux-dvb] compiling on 2.6.28 broken? handygewinnspiel
2009-01-13 18:47         ` handygewinnspiel
2009-01-13 18:59         ` Andrew Morton
2009-01-13 19:17           ` handygewinnspiel
2009-01-13 19:37             ` Andrew Morton
2009-01-13 20:02               ` handygewinnspiel
2009-01-13 20:02                 ` handygewinnspiel
2009-01-13 20:38               ` Matthew Wilcox
2009-01-14 18:29                 ` Chris Mason
2009-01-14 21:19                   ` wk
2009-01-14 21:24                     ` Chris Mason
2009-01-14 21:35                       ` Eric Sandeen
2009-01-14 21:40                         ` Chris Mason
2009-01-14 23:00                           ` Kay Sievers
2009-01-15  1:54                             ` Chris Mason
2009-01-14 21:41                         ` Eric Sandeen
2009-01-14 21:41                           ` Eric Sandeen
2009-01-14 21:44                         ` Andrew Morton
2009-01-14 21:48                           ` Eric Sandeen
2009-01-14 21:48                             ` Eric Sandeen
2009-01-14 22:57                             ` Lachlan McIlroy
2009-01-14 22:57                               ` Lachlan McIlroy
2009-01-18 22:06                             ` Christoph Hellwig
2009-01-18 22:06                               ` Christoph Hellwig
2009-01-14 21:41                       ` wk
2009-01-14 22:30                     ` Dave Chinner
2009-01-15 19:41                       ` wk
2009-01-15 19:41                         ` wk
2009-01-15 22:23                         ` Dave Chinner [this message]
2009-01-10 10:27 handygewinnspiel
     [not found] ` <20090110103700.107530@gmx.net>
2009-01-10 11:07   ` wk
2009-01-10 18:21     ` wk
2009-01-12  5:49       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115222354.GG8071@disturbed \
    --to=david@fromorbit.com \
    --cc=HWerner4@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=handygewinnspiel@gmx.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mchehab@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.