From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86: avoid early crash in disable_local_APIC()
Date: Fri, 16 Jan 2009 14:09:36 +0100 [thread overview]
Message-ID: <20090116130936.GL5421@elte.hu> (raw)
In-Reply-To: <497051E7.76E4.0078.0@novell.com>
* Jan Beulich <jbeulich@novell.com> wrote:
> >>> Ingo Molnar <mingo@elte.hu> 15.01.09 23:47 >>>
> >
> >* Ingo Molnar <mingo@elte.hu> wrote:
> >
> >> hm, this gives a build failure on latest -tip:
> >>
> >> arch/x86/kernel/apic.c: In function 'setup_local_APIC':
> >> arch/x86/kernel/apic.c:1135: error: implicit declaration of function 'disable_ioapic_setup'
>
> Is this with a config that has X86_IO_APIC off (i.e. one the practical
> use of which I never understood, and hence easily forget to consider)?
> Otherwise I can't see how that could happen.
yeah. Such build failures are reminders to define such functions in a
.config-invariant way: i.e. an extern prototype plus an inline NOP-wrapper
for the !IO_APIC case.
Ingo
next prev parent reply other threads:[~2009-01-16 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 12:28 [PATCH] x86: avoid early crash in disable_local_APIC() Jan Beulich
2009-01-15 11:05 ` Ingo Molnar
2009-01-15 22:47 ` Ingo Molnar
2009-01-15 22:47 ` Ingo Molnar
2009-01-16 8:22 ` Jan Beulich
2009-01-16 13:09 ` Ingo Molnar [this message]
2009-01-16 21:26 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116130936.GL5421@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.