From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86: fully honor "nolapic" (take 2)
Date: Fri, 16 Jan 2009 14:42:43 +0100 [thread overview]
Message-ID: <20090116134243.GC14874@elte.hu> (raw)
In-Reply-To: <49709C94.76E4.0078.0@novell.com>
* Jan Beulich <jbeulich@novell.com> wrote:
> >>> Ingo Molnar <mingo@elte.hu> 16.01.09 13:45 >>>
> >
> >* Jan Beulich <jbeulich@novell.com> wrote:
> >
> >> + if (disable_apic) {
> >> +#ifdef CONFIG_X86_IO_APIC
> >> + disable_ioapic_setup();
> >> +#endif
> >> + return;
> >> + }
> >
> > Shouldnt that #ifdef be avoided by always providing the function -
> > just it is a NOP inline in the !CONFIG_X86_IO_APIC case?
>
> That would make for a much bigger patch, since the io_apic.h doesn't
> (and imo shouldn't) be included without that config option.
But we are using io-apic functionality in that file, so we should include
io_apic.h, right?
Ingo
next prev parent reply other threads:[~2009-01-16 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 11:46 [PATCH] x86: fully honor "nolapic" (take 2) Jan Beulich
2009-01-16 12:45 ` Ingo Molnar
2009-01-16 13:41 ` Jan Beulich
2009-01-16 13:42 ` Ingo Molnar [this message]
2009-01-16 13:51 ` Jan Beulich
2009-01-16 13:58 ` Ingo Molnar
2009-01-16 14:09 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116134243.GC14874@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.