From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@suse.cz>
Cc: eric.piel@tremplin-utc.net, trenn@suse.de, linux-kernel@vger.kernel.org
Subject: Re: hp accelerometer: add freefall detection
Date: Fri, 16 Jan 2009 14:34:04 -0800 [thread overview]
Message-ID: <20090116143404.ccf2d9ee.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090116121940.GA30302@elf.ucw.cz>
On Fri, 16 Jan 2009 13:19:40 +0100
Pavel Machek <pavel@suse.cz> wrote:
> new file mode 100755
> index 0000000..7d17764
> --- /dev/null
> +++ b/Documentation/hwmon/hpfall.c
checkpatch has fun with this file.
>
> ...
>
> -struct acpi_lis3lv02d adev;
> +struct acpi_lis3lv02d adev = {
> + .misc_wait = __WAIT_QUEUE_HEAD_INITIALIZER(adev.misc_wait),
> +};
> +
> EXPORT_SYMBOL_GPL(adev);
This seems a rather poor name for a globally-visible identifier.
next prev parent reply other threads:[~2009-01-16 22:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 9:29 hp accelerometer: fix LED handling and add freefall detection Pavel Machek
2009-01-12 9:33 ` Éric Piel
[not found] ` <fd6b62c10901120150q6b00640dm72c0ec5d0bd7a9e2@mail.gmail.com>
2009-01-12 10:02 ` Pavel Machek
2009-01-16 12:19 ` hp accelerometer: " Pavel Machek
2009-01-16 22:34 ` Andrew Morton [this message]
2009-01-20 10:32 ` checkpatch fun (was Re: hp accelerometer: add freefall detection) Pavel Machek
2009-03-10 17:21 ` [PATCH] checkpatch: make -f alias --file, add --help, more verbose help message Hannes Eder
2009-03-10 18:10 ` Andy Whitcroft
2009-03-10 18:52 ` Andy Whitcroft
2009-03-11 8:18 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2009-01-16 22:34 + hp-accelerometer-add-freefall-detection.patch added to -mm tree akpm
2009-02-11 12:33 ` hp accelerometer: add freefall detection Éric Piel
2009-02-13 12:28 ` Pavel Machek
2009-02-14 16:01 ` Frans Pop
2009-03-08 21:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116143404.ccf2d9ee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.