From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 0/2] ftrace: updates to tip
Date: Fri, 16 Jan 2009 16:21:03 +0100 [thread overview]
Message-ID: <20090116152103.GA28643@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0901160929300.22303@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> > maybe we could drive this via the filter API? Something like:
> >
> > echo "*btrfs*:stacktrace" >> set_filter_functions
> >
> > Would automatically mean that those functions will all generate
> > stacktraces too. Note how safe this API is by default: the filter is used
> > for a narrow scope of functions anwyay. To get it for all kernel functions
> > one would have to do:
> >
> > echo "*:stacktrace" >> set_filter_functions
> >
> > Which one cannot do accidentally.
> >
> > What do you think?
>
> Now that I see only a 1/2 sec lag, do you still think this is necessary?
>
> Maybe I should go back and see why it was so bad before?
>
> But I do notice that not all functions produce a valid stack trace.
> Maybe it would be better to add that api :-?
yes - i think that API would be more intuitive, and that way people could
mix more interesting functions (with stack traces) with less important
functions (no stack traces).
Ingo
next prev parent reply other threads:[~2009-01-16 15:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 0:40 [PATCH 0/2] ftrace: updates to tip Steven Rostedt
2009-01-16 0:40 ` [PATCH 1/2] ftrace: fix trace_output Steven Rostedt
2009-01-16 1:40 ` Andrew Morton
2009-01-16 1:46 ` Steven Rostedt
2009-01-16 0:40 ` [PATCH 2/2] ftrace: add stack trace to function tracer Steven Rostedt
2009-01-16 0:48 ` Steven Rostedt
2009-01-16 10:08 ` Frédéric Weisbecker
2009-01-16 14:28 ` Steven Rostedt
2009-01-16 11:19 ` Ingo Molnar
2009-01-16 11:23 ` [PATCH 0/2] ftrace: updates to tip Ingo Molnar
2009-01-16 13:08 ` Frédéric Weisbecker
2009-01-16 13:10 ` Ingo Molnar
2009-01-16 14:32 ` Steven Rostedt
2009-01-16 15:21 ` Ingo Molnar [this message]
2009-01-16 15:53 ` Steven Rostedt
2009-01-16 16:02 ` Ingo Molnar
2009-01-16 16:03 ` Ingo Molnar
2009-01-16 16:22 ` Steven Rostedt
2009-01-16 16:30 ` Ingo Molnar
2009-01-16 22:59 ` Ingo Molnar
2009-01-17 1:14 ` Steven Rostedt
2009-01-17 13:48 ` Frederic Weisbecker
2009-01-17 22:34 ` Ingo Molnar
2009-01-18 7:27 ` Ingo Molnar
2009-01-16 21:47 ` Chris Mason
2009-01-16 22:26 ` Ingo Molnar
2009-01-17 1:30 ` Chris Mason
2009-01-17 2:38 ` Arnaldo Carvalho de Melo
2009-01-19 13:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116152103.GA28643@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.