All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Baker <linux@baker-net.org.uk>
To: video4linux-list@redhat.com, Olivier Lorin <o.lorin@laposte.net>,
	linux-media@vger.kernel.org, Hans de Goede <j.w.r.degoede@hhs.nl>,
	kilgota@banach.math.auburn.edu
Subject: Re: RFC: Where to store camera properties (upside down, needs sw whitebalance, etc). ?
Date: Fri, 16 Jan 2009 20:58:35 +0000	[thread overview]
Message-ID: <200901162058.36080.linux@baker-net.org.uk> (raw)
In-Reply-To: <31415843.70859.1232106194273.JavaMail.www@wwinf8401>

On Friday 16 January 2009, Olivier Lorin wrote:
<snip discussion of cameras needing image flipping capability in libv4l>
> The use of the buffer flags makes the life easier as this flag
> is read for every image. So we can solve for the flip/rotation
> issues with the help of two new buffer flags: V4L2_BUF_FLAG_NEEDS_HFLIP
> and V4L2_BUF_FLAG_NEEDS_VFLIP.
>
> A driver has to set them properly. Does the rotation or flip(s)
> apply to every image (e.g. sensor upside down) or change with frames
> (e.g. Genesys webcams), that no more matters .
> I can do the patch these days.
> I do not remember if there is h/v flip functions in the libv4l,
> maybe they have to be added.
>
> Regards,
> Nol

That sounds like a sensible approach. The flip code is already in libv4l  but 
is currently controlled by a static table (v4lconvert_flags) of cameras that 
need it.

It doesn't address the issue of whether libv4l should also provide gamma 
adjustment, auto white balance and auto gain for cameras that could benefit 
from it. Again that could be done with a static table but keeping the 
knowledge in libv4l in step with the list of supported cameras in the kernel 
won't be easy.

Adam

  reply	other threads:[~2009-01-16 21:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 11:43 Re:RFC: Where to store camera properties (upside down, needs sw whitebalance, etc). ? Olivier Lorin
2009-01-16 20:58 ` Adam Baker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-16 22:56 RFC: " Olivier Lorin
2009-01-17 19:02 ` kilgota
2009-01-20 10:10   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901162058.36080.linux@baker-net.org.uk \
    --to=linux@baker-net.org.uk \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=kilgota@banach.math.auburn.edu \
    --cc=linux-media@vger.kernel.org \
    --cc=o.lorin@laposte.net \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.