From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc64: fix modpost failure
Date: Sun, 18 Jan 2009 07:12:44 +0000 [thread overview]
Message-ID: <20090117.231244.232105333.davem@davemloft.net> (raw)
In-Reply-To: <20090116101449.GA20332@uranus.ravnborg.org>
From: Sam Ravnborg <sam@ravnborg.org>
Date: Fri, 16 Jan 2009 11:14:49 +0100
> Previously PeeCeeI.o was a library but it
> was always pulled in due to insw and friends being exported
> (at least for a modular kernel).
>
> But this resulted in modpost failures if there where no in-kernel
> users because then insw & friends were not linked in.
>
> Fix this by including PeeCeeI.o in the kernel unconditionally.
>
> The only drawback for this solution is that a nonmodular kernel
> will always include insw & friends no matter if they are in use or not.
>
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>
> I have no good suggestion how to fix this if we do not accept
> that they are always pulled in.
This is the correct way to fix this, for sure.
Applied, thanks Sam.
prev parent reply other threads:[~2009-01-18 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 10:14 [PATCH] sparc64: fix modpost failure Sam Ravnborg
2009-01-16 10:48 ` Meelis Roos
2009-01-18 7:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117.231244.232105333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.