Re: git-pull request for omap-fixes for 2.6.29-rc1 (Re: [PATCH 00/10] Omap fixes for 2.6.29-rc1)

[David Brownell <david-b@pacbell.net>]

On Saturday 17 January 2009, Russell King - ARM Linux wrote:
> Now that akpm pushed the usb_port_suspend() fix upstream, we move on
> to the next breakage found by kautobuild, which for n770_defconfig is:
> 
> drivers/built-in.o: In function `ohci_omap_init':
> hid-quirks.c:(.text+0x6c608): undefined reference to `otg_get_transceiver'
> drivers/built-in.o: In function `omap_udc_probe':
> hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
> hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'

Does this fix that problem?

---
 drivers/usb/host/Kconfig |    1 +
 drivers/usb/otg/Kconfig  |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -140,6 +140,7 @@ config USB_OHCI_HCD
 	tristate "OHCI HCD support"
 	depends on USB && USB_ARCH_HAS_OHCI
 	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
+	select USB_OTG_UTILS if ARCH_OMAP
 	---help---
 	  The Open Host Controller Interface (OHCI) is a standard for accessing
 	  USB 1.1 host controller hardware.  It does more in hardware than Intel's
--- a/drivers/usb/otg/Kconfig
+++ b/drivers/usb/otg/Kconfig
@@ -6,14 +6,14 @@
 
 comment "OTG and related infrastructure"
 
-if USB || USB_GADGET
-
 config USB_OTG_UTILS
 	bool
 	help
 	  Select this to make sure the build includes objects from
 	  the OTG infrastructure directory.
 
+if USB || USB_GADGET
+
 #
 # USB Transceiver Drivers
 #