Re: [PATCH/RFC v3 0/6] N-th last checked out branch

[Thomas Rast <trast@student.ethz.ch>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

Johannes Schindelin wrote:
> On Sat, 17 Jan 2009, Thomas Rast wrote:
> >  9 files changed, 387 insertions(+), 122 deletions(-)
> 
> Let's quickly compare that to what Junio sent:
> 
>  builtin-checkout.c |   10 +++++-
>  cache.h            |    1 +
>  sha1_name.c        |   78 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 87 insertions(+), 2 deletions(-)
[...]
> - the '-' handling you seem to want.

Let's be clear that the handling *I* wanted is this big:

 builtin-checkout.c                     |   27 ++++++++++++++++-

In any case, I'll follow up with a version that still traverses the
logs twice and thus doesn't need the first two.

> I really have to ask: why did you not work on top of Junio's patch, just 
> adding docs, tests, and checkout -?  And then -- maybe -- the 
> string_list...
> 
> Although I have to admit that I am not _that_ convinced the string_list is 
> worth it: reflogs are not evaluated all the time, so it is definitely not 
> performance critical.

I take it you have some idea where and how string_list fits into this
topic?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]