From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/?] &&/|| confusion
Date: Sat, 17 Jan 2009 17:15:42 +0000 [thread overview]
Message-ID: <20090117181542.1a3a1bfe@hyperion.delvare> (raw)
In-Reply-To: <4971E2CB.6080307@gmail.com>
On Sat, 17 Jan 2009 15:02:26 +0100, Roel Kluin wrote:
> I wrote:
> > diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
> > index 034b2c5..4a1c9fb 100644
> > --- a/drivers/hwmon/ltc4245.c
> > +++ b/drivers/hwmon/ltc4245.c
> > @@ -456,7 +456,7 @@ static int ltc4245_check_control_reg(struct i2c_client *client, u8 reg, u8 bits)
> > voff1 &= bits;
> > voff2 &= bits;
> >
> > - if (v != voff1 || v != voff2)
> > + if (v != voff1 && v != voff2)
> > return -ENODEV;
> > }
>
>
> On second hand I am not so certain this is wrong. If so, sorry for the noise.
The original code looks OK to me.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-01-17 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 13:53 [lm-sensors] [PATCH 1/?] &&/|| confusion Roel Kluin
2009-01-17 14:02 ` Roel Kluin
2009-01-17 17:15 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117181542.1a3a1bfe@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.