From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems
Date: Sun, 18 Jan 2009 12:58:42 -0500 [thread overview]
Message-ID: <20090118175842.GA15675@infradead.org> (raw)
In-Reply-To: <496E6FB4.8070300@sandeen.net>
On Wed, Jan 14, 2009 at 05:05:24PM -0600, Eric Sandeen wrote:
> allow xfs_freeze to freeze "foreign" filesystems
>
> Now that the freeze ioctl has been elevated to the VFS,
> let's let xfs_io and xfs_freeze freeze other filesystems
> as well - add the CMD_FOREIGN_OK flag to freeze & thaw.
>
> I think the worst that will happen on older kernels is that
> the command will fail with ENOSYS or EINVAL....
Looks good to me, but I thikn you should also update the
xfs_freeze manpage to mention that it works for non-XFS filesystems
on 2.6.29 or newer kernels.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-18 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 23:05 [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems Eric Sandeen
2009-01-15 10:48 ` Bill O'Donnell
2009-01-18 17:58 ` Christoph Hellwig [this message]
2009-01-18 19:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118175842.GA15675@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.