From: Johannes Sixt <j6t@kdbg.org>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 3/7 v2] git_extract_argv0_path(): Move check for valid argv0 from caller to callee
Date: Sun, 18 Jan 2009 20:16:54 +0100 [thread overview]
Message-ID: <200901182016.56395.j6t@kdbg.org> (raw)
In-Reply-To: <1232280015-8144-4-git-send-email-prohaska@zib.de>
On Sonntag, 18. Januar 2009, Steffen Prohaska wrote:
> This simplifies the calling code.
But it could really be squashed into the previous patch, after fixing...
> @@ -23,6 +23,9 @@ const char *system_path(const char *path)
>
> const char *git_extract_argv0_path(const char *argv0)
> {
> + if (!argv0 || !*argv0)
> + return 0;
> +
> const char *slash = argv0 + strlen(argv0);
... this declaration after statement.
-- Hannes
next prev parent reply other threads:[~2009-01-18 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 12:00 [PATCH 0/7 v2] RUNTIME_PREFIX Steffen Prohaska
2009-01-18 12:00 ` [PATCH 1/7 v2] Move computation of absolute paths from Makefile to runtime (in preparation for RUNTIME_PREFIX) Steffen Prohaska
2009-01-18 12:00 ` [PATCH 2/7 v2] Refactor git_set_argv0_path() to git_extract_argv0_path() Steffen Prohaska
2009-01-18 12:00 ` [PATCH 3/7 v2] git_extract_argv0_path(): Move check for valid argv0 from caller to callee Steffen Prohaska
2009-01-18 12:00 ` [PATCH 4/7 v2] Add calls to git_extract_argv0_path() in programs that call git_config_* Steffen Prohaska
2009-01-18 12:00 ` [PATCH 5/7 v2] Modify setup_path() to only add git_exec_path() to PATH Steffen Prohaska
2009-01-18 12:00 ` [PATCH 6/7 v2] Compute prefix at runtime if RUNTIME_PREFIX is set Steffen Prohaska
2009-01-18 12:00 ` [PATCH 7/7 v2] Windows: Revert to default paths and convert them by RUNTIME_PREFIX Steffen Prohaska
2009-01-19 17:41 ` [PATCH 6/7 v2] Compute prefix at runtime if RUNTIME_PREFIX is set Johannes Schindelin
2009-01-18 19:16 ` Johannes Sixt [this message]
2009-01-18 19:28 ` [PATCH 3/7 v2] git_extract_argv0_path(): Move check for valid argv0 from caller to callee Johannes Sixt
2009-01-18 21:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901182016.56395.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.