Re: [git patches] libata hibernation fixes

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Sunday 18 January 2009, Frans Pop wrote:
> Rafael J. Wysocki wrote:
> > There is a name conflict with a change applied after this patchset had
> > been created.  The appended patch fixes it for me.
> [...]
> > @@ -483,7 +483,7 @@ const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list)
> >         const struct dmi_system_id *d; 
> > 
> >         for (d = list; d->ident; d++)
> > -               if (dmi_match(d))
> > +               if (dmi_matches(d))
> >                         return d;
> 
> I get two warnings when compiling your patch with this correction on top:

Hm, there were more patches than one, so I'm not sure.  When I apply all of
them, I don't see these error, but perhaps I should resend the entire series.
Will do tomorrow.

> drivers/firmware/dmi_scan.c: In function ‘dmi_first_match’:
> drivers/firmware/dmi_scan.c:488: warning: return discards qualifiers from pointer target type
> drivers/firmware/dmi_scan.c:483: warning: unused variable ‘i’
> 
> The second is trivial, but the first is beyond me :-/

Thanks,
Rafael