Re: [PATCH 1/2] iwl3945: fix some warnings when compiled without debug

[Helmut Schaa <helmut.schaa@googlemail.com>]

Am Montag, 19. Januar 2009 schrieb Johannes Berg:
> On Mon, 2009-01-19 at 09:55 +0100, Helmut Schaa wrote:
> > Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG=
=2E
> >=20
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_reply_add_sta=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused v=
ariable =E2=80=98pkt=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_results_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused v=
ariable =E2=80=98notif=E2=80=99
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=
wl3945_rx_scan_complete_notif=E2=80=99:
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused v=
ariable =E2=80=98scan_notif=E2=80=99
> >=20
> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > ---
> > diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/=
net/wireless/iwlwifi/iwl3945-base.c
> > index b437cac..15d36d8 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > @@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl=
_priv *priv,
> >  static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
> >  				 struct iwl_rx_mem_buffer *rxb)
> >  {
> > +	#ifdef CONFIG_IWLWIFI_DEBUG
> >  	struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
> > +	#endif=20
>=20
> I for one would definitely prefer you didn't indent preprocessor
> statements, but I don't care all that much about iwl3945.

Indeed. My fault. I'll resend this one.

Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html