From: Valerie Aurora Henson <vaurora@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@linux.kernel.org, Paul Wankadia <junyer@google.com>
Subject: Re: [RFC PATCH 1/3] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit
Date: Mon, 19 Jan 2009 22:05:35 -0500 [thread overview]
Message-ID: <20090120030535.GA1525@shell> (raw)
In-Reply-To: <1232172128.3072.8.camel@zeus.themaw.net>
On Sat, Jan 17, 2009 at 03:02:08PM +0900, Ian Kent wrote:
> On Fri, 2009-01-16 at 19:58 -0800, Valerie Aurora Henson wrote:
> > @@ -1523,18 +1524,12 @@ int lookup_read_master(struct master *master, time_t age, void *context)
> > goto next;
> > }
> >
> > - blen = strlen(*keyValue) + 1 + strlen(*values) + 2;
> > - if (blen > PARSE_MAX_BUF) {
> > + if (snprintf(parse_buf, sizeof(parse_buf), "%s %s",
> > + *keyValue, *values) > sizeof(parse_buf)) {
>
> Think that has to be >=, as Jeff mentioned earlier.
Yes, thanks for catching that and fixing it in your respin.
-VAL
next prev parent reply other threads:[~2009-01-20 3:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 3:58 [RFC PATCH 0/3] Remove alloca(), fix includes Valerie Aurora Henson
2009-01-17 3:58 ` [RFC PATCH 1/3] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit Valerie Aurora Henson
2009-01-17 3:58 ` [RFC PATCH 2/3] Easy alloca() replacements Valerie Aurora Henson
2009-01-17 3:58 ` [RFC PATCH 3/3] Don't include kernel header files during userspace compiles Valerie Aurora Henson
2009-01-17 6:02 ` [RFC PATCH 1/3] Make MAX_ERR_BUF and PARSE_MAX_BUF use easier to audit Ian Kent
2009-01-20 3:05 ` Valerie Aurora Henson [this message]
2009-01-17 5:57 ` [RFC PATCH 0/3] Remove alloca(), fix includes Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120030535.GA1525@shell \
--to=vaurora@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=junyer@google.com \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.