From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] report IRQ injection status to userspace.
Date: Tue, 20 Jan 2009 14:53:40 -0200 [thread overview]
Message-ID: <20090120165340.GA28270@amt.cnet> (raw)
In-Reply-To: <20090120134653.GD27675@redhat.com>
Gleb,
Don't you want IRQ ack notification instead to control reinjection?
Because I think you'll always see a successful injection if using PIC.
On Tue, Jan 20, 2009 at 03:46:53PM +0200, Gleb Natapov wrote:
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 869462c..b2c6b93 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -48,7 +48,10 @@ struct kvm_irq_level {
> * For IA-64 (APIC model) IOAPIC0: irq 0-23; IOAPIC1: irq 24-47..
> * For X86 (standard AT mode) PIC0/1: irq 0-15. IOAPIC0: 0-23..
> */
> - __u32 irq;
> + union {
> + __u32 irq;
> + __s32 status;
> + };
> __u32 level;
> };
And won't this break older userspace?
next prev parent reply other threads:[~2009-01-20 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 13:46 [PATCH] report IRQ injection status to userspace Gleb Natapov
2009-01-20 16:53 ` Marcelo Tosatti [this message]
2009-01-20 17:15 ` Gleb Natapov
2009-01-21 10:03 ` Gleb Natapov
-- strict thread matches above, loose matches on Subject: below --
2009-02-04 11:36 [PATCH] Report " Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120165340.GA28270@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.