From: Vitaliy Gusev <vgusev@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH] kthread: Don't looking for a task in create_kthread() #2
Date: Tue, 20 Jan 2009 17:16:34 +0300 [thread overview]
Message-ID: <200901201716.34842.vgusev@openvz.org> (raw)
In-Reply-To: <20090120120642.GA9497@redhat.com>
On 20 January 2009 15:06:42 Oleg Nesterov wrote:
> On 01/20, Vitaliy Gusev wrote:
> >
> > Remove the unnecessary find_task_by_pid_ns(). kthread() can just
> > use "current" to get the same result.
>
> I think the patch is nice and correct.
>
>
>
> BTW. Perhaps it also makes sense to move sched_setscheduler/etc code
> from create_kthread() to kthread_create(), what do you think?
I don't thinks so. create_kthread() is executed in kthreadd process and
sched_setscheduler/etc preparation things are reflected to kthreadd's CPU usage.
In other words it is a kthreadd matter, start and setup a thread.
>
> (of course, this needs another patch)
>
> Oleg.
>
>
--
Thank,
Vitaliy Gusev
next prev parent reply other threads:[~2009-01-20 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 10:45 [PATCH] kthread: Don't looking for a task in create_kthread() #2 Vitaliy Gusev
2009-01-20 12:06 ` Oleg Nesterov
2009-01-20 14:16 ` Vitaliy Gusev [this message]
2009-01-20 15:00 ` Oleg Nesterov
2009-01-20 17:19 ` Vitaliy Gusev
2009-01-21 15:33 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901201716.34842.vgusev@openvz.org \
--to=vgusev@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.