From: Arnd Bergmann <arnd@arndb.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: mike.mclagan@linux.org, Ingo Molnar <mingo@elte.hu>,
Sam Ravnborg <sam@ravnborg.org>,
netdev@vger.kernel.org, davem@davemloft.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: why usr/include/linux/if_frad.h is required
Date: Tue, 20 Jan 2009 18:47:01 +0100 [thread overview]
Message-ID: <200901201847.03030.arnd@arndb.de> (raw)
In-Reply-To: <1232463242.3088.16.camel@localhost.localdomain>
On Tuesday 20 January 2009, Jaswinder Singh Rajput wrote:
> CC: LKML
>
> On Tue, 2009-01-20 at 20:23 +0530, Jaswinder Singh Rajput wrote:
> > For if_frad.h I am getting two warnings with 'make headers_check':
> > usr/include/linux/if_frad.h:29: leaks CONFIG_DLCI to userspace where it is not valid
> > usr/include/linux/if_frad.h:129: leaks CONFIG_DLCI to userspace where it is not valid
> >
> > Almost all if_frad.h is covered with #if defined(CONFIG_DLCI) || defined(CONFIG_DLCI_MODULE)
> >
> > If I remove this portion so only this what we get in userspace:
> >
> > #ifndef _FRAD_H_
> > #define _FRAD_H_
> >
> > #include <linux/if.h>
> >
> > #endif
> >
> > So I am surprising what is the point of this ?
> >
> > Can I change its name to is_fraud ;-)
The CONFIG_DLCI check in there is clearly in error, the definition in there
is a user interface. The obvious solution is to drop the #if / #endif pair
without a replacement.
Arnd <><
next prev parent reply other threads:[~2009-01-20 17:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 14:52 why usr/include/linux/if_frad.h is required Jaswinder Singh Rajput
2009-01-20 14:54 ` Jaswinder Singh Rajput
2009-01-20 17:47 ` Arnd Bergmann [this message]
2009-01-20 19:53 ` Krzysztof Halasa
2009-01-20 23:48 ` Jaswinder Singh Rajput
2009-01-21 1:06 ` Krzysztof Halasa
2009-01-21 4:50 ` Jaswinder Singh Rajput
2009-01-21 5:33 ` Sam Ravnborg
2009-01-21 6:15 ` David Miller
2009-01-21 6:38 ` Stephen Hemminger
2009-01-21 23:37 ` David Miller
2009-01-22 5:37 ` Sam Ravnborg
2009-01-24 13:25 ` Jaswinder Singh Rajput
2009-01-24 15:32 ` Krzysztof Halasa
2009-01-26 20:30 ` David Miller
2009-01-26 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901201847.03030.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.mclagan@linux.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.