From: Arnd Bergmann <arnd@arndb.de>
To: "Christian Eggers" <ceggers@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers
Date: Tue, 20 Jan 2009 23:45:47 +0100 [thread overview]
Message-ID: <200901202345.47792.arnd@arndb.de> (raw)
In-Reply-To: <34115.192.168.0.40.1232483361.squirrel@server>
On Tuesday 20 January 2009, you wrote:
> From: Christian Eggers <christian.eggers@kathrein.de>
>
> mcs7830_set_reg() and mcs7830_get_reg() are called with buffers
> from stack which must not be used directly for USB transfers.
> This causes corruption of the stack particulary on non x86
> architectures because DMA may be used for these transfers.
>
> Signed-off-by: Christian Eggers <christian.eggers@kathrein.de>
Have you observed problems with this, or just suspected trouble?
When I wrote this code, I looked at other code doing the same
and assumed it was ok, because usb_control_msg waits for the
DMA to complete before returning.
Is the problem only on systems that have noncoherent DMA, or
something else?
> This is my first patch submission for Linux. I hope everything is fine.
I was about to say that you should have Cc:'d me, but then I noticed
that I'm not listed in the driver as maintainer, nor in the MAINTAINERS
file, so I can't really complain here ;-)
Arnd <><
next prev parent reply other threads:[~2009-01-20 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 20:29 [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers Christian Eggers
2009-01-20 20:32 ` David Miller
2009-01-20 22:45 ` Arnd Bergmann [this message]
2009-01-20 22:47 ` David Miller
2009-01-20 23:17 ` Arnd Bergmann
2009-01-20 23:23 ` David Miller
2009-01-20 23:36 ` Oliver Neukum
2009-01-20 23:37 ` Arnd Bergmann
2009-01-20 23:39 ` David Miller
2009-01-20 23:28 ` Oliver Neukum
2009-01-20 22:50 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901202345.47792.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ceggers@gmx.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.