From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check' Date: Wed, 21 Jan 2009 06:41:38 +0100 Message-ID: <20090121054138.GA26551@uranus.ravnborg.org> References: <1232465902.3088.31.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pfepa.post.tele.dk (pfepa.post.tele.dk [195.41.46.235]) by alsa0.perex.cz (Postfix) with ESMTP id 910A1103858 for ; Wed, 21 Jan 2009 06:39:53 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Jaswinder Singh Rajput , Ingo Molnar , LKML List-Id: alsa-devel@alsa-project.org On Wed, Jan 21, 2009 at 01:08:37AM +0100, Takashi Iwai wrote: > At Tue, 20 Jan 2009 21:08:22 +0530, > Jaswinder Singh Rajput wrote: > > > > usr/include/linux/soundcard.h is giving following warnings for 'make headers_check': > > usr/include/linux/soundcard.h:1047: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1048: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1049: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1050: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1051: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1053: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1055: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1056: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1061: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1062: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1078: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1079: extern's make no sense in userspace > > > > Do we need to fix these warnings. > > No, these are declarations for OSS-lib. > It doesn't belong to kernel, but it's better to keep it for > compatibility in some way. But not in the kernel for sure. I just checked and for example: OSS_init is not used anywhere in the kernel. The kernel headers are not a "dump all your stuff" ground anymore. So I encourage you to find a better home for the user space library definitons. We can let the definiton stay for a while - but eventually they have to be dropped from the kernel. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759129AbZAUFkF (ORCPT ); Wed, 21 Jan 2009 00:40:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750805AbZAUFjy (ORCPT ); Wed, 21 Jan 2009 00:39:54 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:33553 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbZAUFjx (ORCPT ); Wed, 21 Jan 2009 00:39:53 -0500 Date: Wed, 21 Jan 2009 06:41:38 +0100 From: Sam Ravnborg To: Takashi Iwai Cc: Jaswinder Singh Rajput , alsa-devel@alsa-project.org, Ingo Molnar , LKML Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check' Message-ID: <20090121054138.GA26551@uranus.ravnborg.org> References: <1232465902.3088.31.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 21, 2009 at 01:08:37AM +0100, Takashi Iwai wrote: > At Tue, 20 Jan 2009 21:08:22 +0530, > Jaswinder Singh Rajput wrote: > > > > usr/include/linux/soundcard.h is giving following warnings for 'make headers_check': > > usr/include/linux/soundcard.h:1047: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1048: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1049: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1050: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1051: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1053: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1055: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1056: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1061: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1062: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1078: extern's make no sense in userspace > > usr/include/linux/soundcard.h:1079: extern's make no sense in userspace > > > > Do we need to fix these warnings. > > No, these are declarations for OSS-lib. > It doesn't belong to kernel, but it's better to keep it for > compatibility in some way. But not in the kernel for sure. I just checked and for example: OSS_init is not used anywhere in the kernel. The kernel headers are not a "dump all your stuff" ground anymore. So I encourage you to find a better home for the user space library definitons. We can let the definiton stay for a while - but eventually they have to be dropped from the kernel. Sam