Re: [PATCH ver2 printk_ratelimit] bsg: Error print if device is not bidi capable when refusing a bidi command

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Jan 20 2009, Boaz Harrosh wrote:
> Boaz Harrosh wrote:
> > Jens Axboe wrote:
> >> Thanks, that works. But why isn't the -EOPNOTSUPP error return (which the
> >> app can see and print info about) enough? Do we really need to put this
> >> in the kernel log?
> >>
> > 
> > 
> > But let me check I had problems with the return value.
> 
> OK I found my problem, blush:
> 
> -		ret = ioctl(fd, SG_IO, &sg);
> +		ret = ioctl(fd, SG_IO, &sg) ? -errno : 0;
> 
> So if I do a print to stderr in the lowest-most library will
> that be visible enough to an Admin. I have utils like
> osd_format, mkfs.exofs, a FUSE filesystem ...
> OK I can always redirect stderr to the dmsg log

Goodie, that saves us that printk() :-)

-- 
Jens Axboe