From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] Fix almost infinite loop in APIC Date: Wed, 21 Jan 2009 14:55:28 -0200 Message-ID: <20090121165528.GB10629@amt.cnet> References: <1231432566-9864-1-git-send-email-agraf@suse.de> <200901211040.49733.sheng@linux.intel.com> <20090121042330.GA14894@amt.cnet> <200901211311.24352.sheng@linux.intel.com> <20090121150700.GA10018@amt.cnet> <49774AB8.6070108@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sheng Yang , kvm@vger.kernel.org, avi@redhat.com, Kevin Wolf To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37049 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091AbZAUQzv (ORCPT ); Wed, 21 Jan 2009 11:55:51 -0500 Content-Disposition: inline In-Reply-To: <49774AB8.6070108@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jan 21, 2009 at 05:18:00PM +0100, Alexander Graf wrote: > Marcelo Tosatti wrote: > > On Wed, Jan 21, 2009 at 01:11:23PM +0800, Sheng Yang wrote: > > > >> Use ktime_to_ns() macro is better. > >> > >> The remaining parts are fine with me. But please do more test. :) > >> > >> Thanks for work! > >> > > > > Alexander, can you please confirm this works for you, thanks. > > > > Looks good so far. I can't really tell if it's doing the right thing, > but at least it's not crashing the host anymore ;). And the VM does come > up (somewhat). What might be going wrong there is if there are accumulated interrupts to be injected (pending > 0). You might want to check that in apic_get_tmcct. > Signed-off-by: Alexander Graf Thanks