From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alasdair G Kergon Subject: Re: [PATCH 1/2] dm-ioband: I/O bandwidth controller v1.10.0: Source code and patch Date: Wed, 21 Jan 2009 17:18:17 +0000 Message-ID: <20090121171817.GP9859@agk.fab.redhat.com> References: <20090120.141022.193708059.ryov@valinux.co.jp> <20090120.141114.226778416.ryov@valinux.co.jp> <20090120145208.GE9859@agk.fab.redhat.com> <20090121.220356.39155811.ryov@valinux.co.jp> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090121.220356.39155811.ryov@valinux.co.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Ryo Tsuruta Cc: dm-devel@redhat.com List-Id: dm-devel.ids I'm asking whether or not restructuring that little bit of code would improve clarity, or whether it would become more convoluted. Last time we had this, changing the functions so locks were acquired then released actually improved clarity - I'm asking if the same is true here or not. Alasdair -- agk@redhat.com