Re: [RFC] Add option for strict checksumming, was: Re: checksums...

[Tom Rini <trini@kernel.crashing.org>]

On Wed, Jan 21, 2009 at 08:34:51PM +0100, Koen Kooi wrote:
> On 21-01-09 20:15, Philip Balister wrote:
>> Koen Kooi wrote:
>>> Hi,
>>>
>>> Could people adding new recipe and people git-am'ing patches adding
>>> new recipes please add the corresponding checksums to checksums.ini?
>>>
>>> It's not hard:
>>>
>>> 1) bitbake <recipe>
>>> 2) watch it fail
>>> 3) cd $TMPDIR ; cat /OE/org.openembedded.dev/conf/checksums.ini >>
>>> checksums.ini ; python
>>> /OE/org.openembedded.dev/contrib/source-checker/oe-checksums-sorter.py
>>> checksums.ini > /OE/org.openembedded.dev/conf/checksums.ini
>>> 4) git commit --amend /OE/org.openembedded.dev/conf/checksums.ini
>>
>> I screwed this up once (and committed a recipe without the checksum)
>> when I left ALLOW_INSECURE_DOWNLOADS set in my local.conf. Now I have it
>> commented out and am really careful only to use it only when hacking.
>
> What about this:
>
> From a48ee59ac6ea569a5f88066d86de4b66d8f606c3 Mon Sep 17 00:00:00 2001
> From: Koen Kooi <koen@openembedded.org>
> Date: Wed, 21 Jan 2009 20:29:53 +0100
> Subject: [PATCH] base.bbclass: only error out on missing checksums when  
> OE_STRICT_CHECKSUMS is set
>  * we want to error out on non-matching sums, missing ones are less bad

This will bring us back to where we started.  I think we just need to
live with the pain a bit more and get people used to "Oops, no checksum
in your patch" ...

And btw, git commit --amend will let you change things in the last
commit you made.  ONLY do this if you haven't also done a push.

-- 
Tom Rini