From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Cc: "Liu, Jinsong" <jinsong.liu@intel.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH 1/4]X86 microcode: cancel redundant input parameter of microcode functions
Date: Thu, 22 Jan 2009 09:42:01 +0100 [thread overview]
Message-ID: <200901220942.02201.Christoph.Egger@amd.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC2223BD253@pdsmsx503.ccr.corp.intel.com>
On Thursday 22 January 2009 04:08:21 Liu, Jinsong wrote:
> X86 microcode: cancel redundant input parameter of microcode functions
>
> Cancel redundant input parameter 'uci', since it can get from another input
> parameter 'cpu' as index.
>
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
I added the parameter 'uci' to reduce dependency on a global variable.
That improves reentrancy and cache locality.
If you want to go a step forward rather back, then remove the 'cpu' parameter
instead.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2009-01-22 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 3:08 [PATCH 1/4]X86 microcode: cancel redundant input parameter of microcode functions Liu, Jinsong
2009-01-22 8:42 ` Christoph Egger [this message]
2009-01-22 10:54 ` Liu, Jinsong
2009-01-22 11:07 ` Christoph Egger
2009-01-22 11:14 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901220942.02201.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=jinsong.liu@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.