diff for duplicates of <200901221255.49724.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index 01bd21c..3fdeabf 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,18 @@ On Thursday 22 January 2009, Anton Vorontsov wrote: -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * These accessors duplicate s= -dhci_ops, but there are two reasons for -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * this: -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 1. sdhci_ops are const, so = -the sdhci driver won't able to assign -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0default ops; +> + /* +> + * These accessors duplicate sdhci_ops, but there are two reasons for +> + * this: +> + * 1. sdhci_ops are const, so the sdhci driver won't able to assign +> + * default ops; You could assign the pointer to a const default_sdhci_ops structure, which IMHO would be cleaner than copying the function pointers separately. -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 2. Using host->X instead of= - host->ops->X saves us one dereference. -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0This can be us= -eful in PIO mode. (Though the benefit of this -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0is negligibly = -small). -> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ +> + * 2. Using host->X instead of host->ops->X saves us one dereference. +> + * This can be useful in PIO mode. (Though the benefit of this +> + * is negligibly small). +> + */ I doubt that this is even measurable. If it was, you could still use a copy of that structure, like @@ -32,7 +27,7 @@ and do an assignment of the structure, like static void assign_ops(struct sdhci_host *host, struct sdhci_ops *ops) { - host->ops =3D *ops; + host->ops = *ops; } Arnd <>< diff --git a/a/content_digest b/N1/content_digest index 359cff9..0a056ea 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,37 +4,33 @@ "Subject\0Re: [PATCH 02/10] sdhci: Add support for bus-specific IO memory accessors\0" "Date\0Thu, 22 Jan 2009 12:55:48 +0100\0" "To\0Anton Vorontsov <avorontsov@ru.mvista.com>\0" - "Cc\0sdhci-devel@list.drzeus.cx" - linux-kernel@vger.kernel.org + "Cc\0Pierre Ossman <drzeus-sdhci@drzeus.cx>" + Ben Dooks <ben-linux@fluff.org> + Kumar Gala <galak@kernel.crashing.org> Liu Dave <DaveLiu@freescale.com> - Joe D'Abbraccio <Joe.D'abbraccio@freescale.com> - linuxppc-dev@ozlabs.org + Xie Xiaobo <X.Xie@freescale.com> Konjin Lai <Konjin.Lai@freescale.com> - Ben Dooks <ben-linux@fluff.org> - Pierre Ossman <drzeus-sdhci@drzeus.cx> - " Xie Xiaobo <X.Xie@freescale.com>\0" + Joe D'Abbraccio <Joe.D'abbraccio@freescale.com> + sdhci-devel@list.drzeus.cx + linux-kernel@vger.kernel.org + " linuxppc-dev@ozlabs.org\0" "\00:1\0" "b\0" "On Thursday 22 January 2009, Anton Vorontsov wrote:\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/*\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * These accessors duplicate s=\n" - "dhci_ops, but there are two reasons for\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * this:\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 1. sdhci_ops are const, so =\n" - "the sdhci driver won't able to assign\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0default ops;\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240/*\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * These accessors duplicate sdhci_ops, but there are two reasons for\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * this:\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * 1. sdhci_ops are const, so the sdhci driver won't able to assign\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * \302\240 \302\240default ops;\n" "\n" "You could assign the pointer to a const default_sdhci_ops structure,\n" "which IMHO would be cleaner than copying the function pointers\n" "separately.\n" "\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 2. Using host->X instead of=\n" - " host->ops->X saves us one dereference.\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0This can be us=\n" - "eful in PIO mode. (Though the benefit of this\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * =C2=A0 =C2=A0is negligibly =\n" - "small).\n" - "> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * 2. Using host->X instead of host->ops->X saves us one dereference.\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * \302\240 \302\240This can be useful in PIO mode. (Though the benefit of this\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * \302\240 \302\240is negligibly small).\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 */\n" "\n" "I doubt that this is even measurable. If it was, you could still use a copy\n" "of that structure, like\n" @@ -49,9 +45,9 @@ "\n" "static void assign_ops(struct sdhci_host *host, struct sdhci_ops *ops)\n" "{\n" - "\thost->ops =3D *ops;\n" + "\thost->ops = *ops;\n" "}\n" "\n" "\tArnd <><" -da2297ebc05f278aa5f414c66ed538a1cf78b50bedb9866a83888b28a502a3fd +7d4ebe1d5f34d986d8f0229b0d0750ef8c1f0ca4f2f7fcec4960027b0e123133
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.