From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] iwl3945: Remove unused variables
Date: Thu, 22 Jan 2009 20:08:14 +0100 [thread overview]
Message-ID: <200901222008.14597.helmut.schaa@gmail.com> (raw)
In-Reply-To: <1ba2fa240901220328s4fe65faeo35176357a19f57fa@mail.gmail.com>
Am Donnerstag, 22. Januar 2009 schrieb Tomas Winkler:
> On Thu, Jan 22, 2009 at 12:44 PM, Helmut Schaa
> <helmut.schaa@googlemail.com> wrote:
> > Am Mittwoch, 21. Januar 2009 schrieb John W. Linville:
> >> On Mon, Jan 19, 2009 at 09:55:32AM +0100, Helmut Schaa wrote:
> >> > Fix the following warnings in iwl-3945-rs.c by removing unused variables.
> >> >
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_rate_scale_flush_windows':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:186: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_bg_rate_scale_flush':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:219: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_collect_tx_data':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'rs_free_sta':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: warning: unused variable 'priv'
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_get_adjacent_rate':
> >> > drivers/net/wireless/iwlwifi/iwl-3945-rs.c:559: warning: unused variable 'priv'
> >> >
> >> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> >>
> >> With this applied, I get these:
> >>
> >> CC [M] drivers/net/wireless/iwlwifi/iwl-3945-rs.o
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_rate_scale_flush_windows':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: (Each undeclared identifier is reported only once
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:199: error: for each function it appears in.)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_bg_rate_scale_flush':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:222: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_collect_tx_data':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'rs_free_sta':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: error: 'priv' undeclared (first use in this function)
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function 'iwl3945_get_adjacent_rate':
> >> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:594: error: 'priv' undeclared (first use in this function)
> >> make[2]: *** [drivers/net/wireless/iwlwifi/iwl-3945-rs.o] Error 1
> >> make[1]: *** [drivers/net/wireless/iwlwifi] Error 2
> >> make: *** [drivers/net/wireless/] Error 2
> >>
> >> Dropping...
> >
> > Ah, sorry for that. I compiled without CONFIG_IWL_DEBUG. Instead of removing
> > these lines they should be surrounded by an CONFIG_IWL_DEBUG check. I'll send
> > that soon.
>
> Please use
> struct iwl_priv *priv __maybe_unused priv;
> look at in iwl-agn-rs.c
Will do. Thanks for the hint.
Helmut
prev parent reply other threads:[~2009-01-22 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 8:55 [PATCH 2/2] iwl3945: Remove unused variables Helmut Schaa
2009-01-19 13:06 ` samuel
2009-01-21 19:23 ` John W. Linville
2009-01-22 10:44 ` Helmut Schaa
2009-01-22 11:28 ` Tomas Winkler
2009-01-22 19:08 ` Helmut Schaa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901222008.14597.helmut.schaa@gmail.com \
--to=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.