From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: Eero Nurkkala <ext-eero.nurkkala@nokia.com>,
linux-omap@vger.kernel.org, "ext Lopez Cruz,
Misael" <x0052729@ti.com>
Subject: Re: v2.6.28-omap1 tagged, some bugs remain
Date: Thu, 22 Jan 2009 16:02:21 -0800 [thread overview]
Message-ID: <20090123000220.GE7172@atomide.com> (raw)
In-Reply-To: <20090119095429.629b2606.jarkko.nikula@nokia.com>
* Jarkko Nikula <jarkko.nikula@nokia.com> [090118 23:54]:
> On Wed, 14 Jan 2009 17:28:07 +0200
> "ext Tony Lindgren" <tony@atomide.com> wrote:
>
> > > You need to have the counterpart (in /sound/soc/omap/omap-mcbsp.c) for
> > > that patch, othwerwise there's no chance to hear any DMA transferred
> > > audio.
> >
> > Jarkko, can you post the patch queued up for alsa? We might want to
> > have that in linux-omap too.
> >
> Patch was made by Misael and I think he is waiting until the plat-omap
> part goes into mainline. And which means that OMAP3 audio is broken
> until sound/soc/omap/omap-mcbsp.c is patched.
>
> I would say that we wouldn't want to hack with sound/ directory in
> linux-omap. Especially code which is not in Takashi's tree since then
> we have yet another conflict point if one wants to merge from his tree
> on top of linux-omap.
>
> Probably we should revert the patch and split it into three
> separate patches:
>
> 1. Header change in linux-omap adding those registers (and queue it)
> 2. Patch to alsa-devel setting default values to those registers
> 3. Patch to linux-omap writing those registers
OK, I've reverted #3 above in l-o master and omap-2.6.28 branches.
> Or better: send those two patches to LKML, cc linux-omap and alsa-devel
> and let it fall down from -mm or linux-next tree.
Well since #3 is already queued in omap-fixes, I'd rather let it go to
mainline and not mess with that queue.
Maybe after that you could try to get #1 & #2 above merged to mainline
via alsa-devel list as one patch?
Regards,
Tony
next prev parent reply other threads:[~2009-01-23 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 8:27 v2.6.28-omap1 tagged, some bugs remain Eero Nurkkala
2009-01-14 15:28 ` Tony Lindgren
2009-01-19 7:54 ` Jarkko Nikula
2009-01-23 0:02 ` Tony Lindgren [this message]
2009-01-23 7:49 ` Jarkko Nikula
-- strict thread matches above, loose matches on Subject: below --
2009-01-12 14:50 Tony Lindgren
2009-01-12 15:39 ` Koen Kooi
2009-01-12 16:15 ` Tony Lindgren
2009-01-13 7:08 ` Jarkko Nikula
2009-01-13 15:37 ` Anuj Aggarwal
2009-01-15 14:53 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123000220.GE7172@atomide.com \
--to=tony@atomide.com \
--cc=ext-eero.nurkkala@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.